Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce sign_with method in keystore #4925

Merged
merged 73 commits into from
Mar 30, 2020
Merged

Introduce sign_with method in keystore #4925

merged 73 commits into from
Mar 30, 2020

Commits on Feb 17, 2020

  1. Add KEY_KIND_ID to the public trait 

    This change is being introduced for the purpose of identifying a public
key with it's identifier and algorithm "kind".
    @rakanalh
    rakanalh committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    ad44d72 View commit details
    Browse the repository at this point in the history

  2. Use sign_with as implemented in BareCryptoStore

    @rakanalh
    rakanalh committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    3199d1e View commit details
    Browse the repository at this point in the history

  3. Implement sign_with in sc_keystore

    @rakanalh
    rakanalh committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    25f4a5c View commit details
    Browse the repository at this point in the history

  4. Fix inconsistencies, use *_KIND_ID in sp_core testing

    @rakanalh
    rakanalh committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    8cc6dfd View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Rename KeyKindId to CryptoTypeId

    @rakanalh
    rakanalh committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    4895e80 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Remove pair-returning functions from BareCryptoStore trait

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    42f426d View commit details
    Browse the repository at this point in the history

  2. Define CryptoTypeId in app-crypto macros

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    35555ff View commit details
    Browse the repository at this point in the history

  3. Add functions to get keys supported by keystore

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d7623c7 View commit details
    Browse the repository at this point in the history

  4. Fix sign_with signature to include CryptoTypePublicPair

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    01af73e View commit details
    Browse the repository at this point in the history

  5. Add sign_with_any and sign_with_all

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    97775db View commit details
    Browse the repository at this point in the history

  6. Use keystore.sign_with in auth_discovery

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    1ee13ac View commit details
    Browse the repository at this point in the history

  7. Rename get_supported_keys -> supported_keys

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    ccec7f5 View commit details
    Browse the repository at this point in the history

  8. Added headers to function docstrings

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    5f59041 View commit details
    Browse the repository at this point in the history

  9. Use chain instead of extending a temp vector

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    b588f7f View commit details
    Browse the repository at this point in the history

  10. Fixed some code formatting

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    94e45a9 View commit details
    Browse the repository at this point in the history

  11. Restrict size of CryptoTypeId 

    This is to be able to use Encode/Decode derives and the overcome having
the size being unknown at compile-time.
    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    e19ecf6 View commit details
    Browse the repository at this point in the history

  12. Implement sign_with in the trait itself

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    12836f4 View commit details
    Browse the repository at this point in the history

  13. Remove whitespace

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d6082cc View commit details
    Browse the repository at this point in the history

  14. Use key_type also as a CryptoTypeId in app_crypto macros

    @rakanalh
    rakanalh committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    ef029eb View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Rename get_keys to keys in BareCryptoStore

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    c9680e3 View commit details
    Browse the repository at this point in the history

  2. Remove usage of key_pair funcs in tests

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    9dd7929 View commit details
    Browse the repository at this point in the history

  3. Adjust docstring for *_CYPTO_ID constants

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    4d0b81b View commit details
    Browse the repository at this point in the history

  4. Fix failures

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    0956ef7 View commit details
    Browse the repository at this point in the history

  5. Simplify mapping on keys

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    02f7099 View commit details
    Browse the repository at this point in the history

  6. Remove one let

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    79290de View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into sign_with

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    1ff324b View commit details
    Browse the repository at this point in the history

  8. Fixed typo

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    6a06530 View commit details
    Browse the repository at this point in the history

  9. PR feedback

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    6c37161 View commit details
    Browse the repository at this point in the history

  10. remove whitespace

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    ea81fba View commit details
    Browse the repository at this point in the history

  11. Zip keys and signatures

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    118a53c View commit details
    Browse the repository at this point in the history

  12. Use into_iter & remove cloned

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    eaa1c80 View commit details
    Browse the repository at this point in the history

  13. Pass index to MissingSignature

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    bf42dec View commit details
    Browse the repository at this point in the history

  14. Use typed errors instead of strings for BareCryptoStore

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    17dd9a2 View commit details
    Browse the repository at this point in the history

  15. Implement Debug for trait error

    @rakanalh
    rakanalh committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    25c9bdd View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Use hashsets for better performance for supported_keys

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    b6de5e6 View commit details
    Browse the repository at this point in the history

  2. Make sure keys are inserted into the keystore

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6cad7b9 View commit details
    Browse the repository at this point in the history

  3. Make sign_with_all return type consistent with sign_with

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    87e13fa View commit details
    Browse the repository at this point in the history

  4. Rename Error to BareCryptoStoreError

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    a7bfe13 View commit details
    Browse the repository at this point in the history

  5. Rename CRYPT_TYPE_ID -> CRYPTO_ID

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    7d38383 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary CRYPTO_ID declaration in Public trait

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    321f16c View commit details
    Browse the repository at this point in the history

  7. Convert pub key to CryptoTypePublicPair

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    69f474e View commit details
    Browse the repository at this point in the history

  8. Fix use

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    164d16b View commit details
    Browse the repository at this point in the history

  9. Fix code style

    @rakanalh
    rakanalh committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    c120f12 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. Implement From on CryptoTypePublicPair in app_crypto macros

    @rakanalh
    rakanalh committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    fe8cf28 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Change CryptoTypePublicPair to a struct

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    19c7499 View commit details
    Browse the repository at this point in the history

  2. Implement Display on CryptoTypePublicPair

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    499c1bb View commit details
    Browse the repository at this point in the history

  3. Pass CryptoTypePublicPair to MissingSignature error

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    b42af41 View commit details
    Browse the repository at this point in the history

  4. Adjust docs according to function signature

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    fc40b1e View commit details
    Browse the repository at this point in the history

  5. Unify keys implementation

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    bca2c90 View commit details
    Browse the repository at this point in the history

  6. Fix RPC author tests

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    79b7e23 View commit details
    Browse the repository at this point in the history

  7. Fix stackoverflow

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    31ae7ce View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into sign_with

    @rakanalh
    rakanalh committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    6696aa0 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Tabify spaces

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    5de1d04 View commit details
    Browse the repository at this point in the history

  2. Pass KeyTypeId to error for easier debugging

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    47f6c08 View commit details
    Browse the repository at this point in the history

  3. Fix asserts

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    1674645 View commit details
    Browse the repository at this point in the history

  4. Use ToHex to format public key

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    94651fa View commit details
    Browse the repository at this point in the history

  5. Use constants from sp_core

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    c71646a View commit details
    Browse the repository at this point in the history

  6. Rename testing KeyTypeId constants

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    46d6f23 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into sign_with

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    f4d231e View commit details
    Browse the repository at this point in the history

  8. Please compiler

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    bc0880b View commit details
    Browse the repository at this point in the history

  9. Restore KeyTypeId names 

    apparently, they're not only used in tests
    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    c8b721c View commit details
    Browse the repository at this point in the history

  10. Use BareCryptoStoreError instead of String

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    fbfd23b View commit details
    Browse the repository at this point in the history

  11. Document return value

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    cac19ad View commit details
    Browse the repository at this point in the history

  12. Fix borrow check

    @rakanalh
    rakanalh committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    d5f4c4b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Convert to hashset internally

    @rakanalh
    rakanalh committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    c007d13 View commit details
    Browse the repository at this point in the history

  2. WIP - iter_keys

    @rakanalh
    rakanalh committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    9874c96 View commit details
    Browse the repository at this point in the history

  3. Return raw_public_keys

    @rakanalh
    rakanalh committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    f6be826 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Address PR feedback

    @rakanalh
    rakanalh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    0c012e7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into sign_with

    @rakanalh
    rakanalh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    145d876 View commit details
    Browse the repository at this point in the history

  3. Address PR Feedback

    @rakanalh
    rakanalh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    9e80c07 View commit details
    Browse the repository at this point in the history

  4. Fix hexdisplay import error

    @rakanalh
    rakanalh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7b92399 View commit details
    Browse the repository at this point in the history

  5. Update primitives/core/src/traits.rs

    @bkchr
    bkchr committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7908f71 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Merge remote-tracking branch 'upstream/master' into sign_with2

    @rakanalh
    rakanalh committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5f9ad09 View commit details
    Browse the repository at this point in the history