This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Utility/Recovery passthrough always pays a fee. #4953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
A0-please_review
bkchr
previously approved these changes
Feb 17, 2020
|
@bkchr lets put this on ice, I will try to use @kianenigma new FunctionOf syntax and update all passthrough logic |
shawntabrizi
changed the title
shawntabrizi
removed
the
A2-insubstantial
bkchr
approved these changes
Feb 17, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Feb 18, 2020
* Utility passthrough always pays a fee. * Use `FunctionOf` instead of Passthrough * Update recovery passthrough
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic around calculating the weight and fees for passthrough calls in the Utility pallet.
This makes it so that passthrough calls always pay a fee to avoid allowing users to spam the network with potentially free transactions which cost computation.
Additionally we use the
FunctionOfstruct to standardize the way we calculate custom weight information. The calculations themselves (other thanpays_fee = true) should be unchanged.