This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into td-offchain-signing
Test failing... |
Test failures seem to be related. |
tomusdrw
approved these changes
Apr 21, 2020
kianenigma
reviewed
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes, as already approved.
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…ech#985) * Implement offchain::SendTransactionTypes * Fix test-runtime * Fix Kusama * Add SendTransactiontypes to Kusama * impl SendTransactiontypes for parachains and registrar * Fix typos * Provided extrinsic type * Implement AppCrypto for signing transactions * Add signing capabilities to runtime * Fix test runtimes * Implement CreateSignedtransaction for Test * Implement signing types for test runtimes * Fix test runtime create transaction impl * Fix build * Bump kusama's spec version * Update substrate * Use all_accounts
jordy25519
added a commit
to plugblockchain/plug-blockchain
that referenced
this pull request
Sep 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a new implementation to offchain worker signing related tasks where:
Resolves #5213
TODOs
CreateTransaction
in testsPolkadot companion: paritytech/polkadot#985