Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Offchain signing #5182

Merged
merged 131 commits into from
Apr 21, 2020
Merged

Offchain signing #5182

merged 131 commits into from
Apr 21, 2020

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Mar 7, 2020

This PR is a new implementation to offchain worker signing related tasks where:

  • The signing interface is simplified
  • In addition to submitting a signed / (raw) unsigned transactions, this also introduces a way to submit unsigned transactions with signed payloads.

Resolves #5213

TODOs

  • Merge latest master
  • Remove usage of CreateTransaction in tests
  • Port the staking pallet if merged.
  • Implement companion Polkadot PR.

Polkadot companion: paritytech/polkadot#985

@gavofyork
Copy link
Member

Test failing...

@tomusdrw tomusdrw added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A5-grumble labels Apr 17, 2020
@rakanalh rakanalh added A8-mergeoncegreen and removed A3-needsresolving A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 17, 2020
@kianenigma
Copy link
Contributor

Test failures seem to be related.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes, as already approved.

@tomusdrw tomusdrw merged commit b20dc82 into master Apr 21, 2020
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
…ech#985)

* Implement offchain::SendTransactionTypes

* Fix test-runtime

* Fix Kusama

* Add SendTransactiontypes to Kusama

* impl SendTransactiontypes for parachains and registrar

* Fix typos

* Provided extrinsic type

* Implement AppCrypto for signing transactions

* Add signing capabilities to runtime

* Fix test runtimes

* Implement CreateSignedtransaction for Test

* Implement signing types for test runtimes

* Fix test runtime create transaction impl

* Fix build

* Bump kusama's spec version

* Update substrate

* Use all_accounts
jordy25519 added a commit to plugblockchain/plug-blockchain that referenced this pull request Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New abstractions for signing for off-chain workers
8 participants