Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Explicit 'extern crate proc_macro;' is needed for stable channel #5690

Closed
wants to merge 1 commit into from

Conversation

infinity0
Copy link
Contributor

@infinity0 infinity0 commented Apr 17, 2020

As a follow-up to PR #3844, this PR is needed to make things work for rustc 1.42 stable with nightly features enabled.

The background is rust-lang/rust#54116 and in particular see rust-lang/rust#53166 (comment)

@parity-cla-bot
Copy link

It looks like @infinity0 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@bkchr
Copy link
Member

bkchr commented Apr 17, 2020

You are linking issues from 2018, I don't think that anything from 2018 applies today. Especially as with 1.42, it is not required anymore to put a extern crate proc_macro; to your crate. See this.

And, we always compile with Rust stable and everything works ;)

@bkchr bkchr closed this Apr 17, 2020
@infinity0
Copy link
Contributor Author

Ah, the issue must be cargo, we still have an outdated version of cargo in Debian.

@bkchr
Copy link
Member

bkchr commented Apr 18, 2020

Probably.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants