This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow specifying listening multiaddresses #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a note, I opened this PR because I find the idea cool, but I'm not going to argue that this is something we want to provide. |
arkpar
approved these changes
Aug 20, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
gavofyork
approved these changes
Aug 28, 2018
dvdplm
added a commit
that referenced
this pull request
Aug 29, 2018
* master: Contracts: Per block gas limit (#506) Make sure to ban invalid transactions. (#615) (#620) Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619) Allow specifying listening multiaddresses (#577) Introduce Runtime Events (#607) update substrate/extrinsic-pool (#616) add a new unit test for extrinsic pool (#611) set the current repo in Cargo.toml (#610) add cli for purge chain (#609)
dvdplm
added a commit
that referenced
this pull request
Sep 3, 2018
…rs-generic-over-hasher-and-rlpcodec * origin/master: (26 commits) Contract runtime polishing (#601) WIP on chain heap (#639) Events to track extrinsic success (#640) Install llvm-tools-preview component (#643) fix wasm executor compile error (#631) random fixes (#638) Empty becomes (), reflecting convention (#637) Allow to build_upon skipped entries, but don't walk back (#635) Separate out staking module into balances and payment (#629) Update .gitlab-ci.yml (#633) Do not attempt to rustup if in CI. This is taken care of by the base (#621) Avoid need for ident strings in storage (#624) rename to panic_handler as panic_implementation is deprecated in nightly (#626) 5 random fixes (#2) (#623) fix one typo in README (#627) Misspelled words (#625) Contracts: Per block gas limit (#506) Make sure to ban invalid transactions. (#615) (#620) Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619) Allow specifying listening multiaddresses (#577) ...
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Allow Root to add a claim. * Additional test * Update lock
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Build mainnet config * Set initial authorities * The initial authorities should not be chilled * Update tech commitee * Change Proxy index to 36 * Update btc mainnet genesis header to 694500 * Check btc trustees config * Run cargo fmt * Checked validator count * Disable the bootnodes for now * 3.0.0 * build-spec --raw > chainx_regenesis.json * Fmt * Ignore the failing test * Add bootnodes to chainx_regenesis.json
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Remove commented code Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Ensure substitue path is global absolute Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Absolute path for build.rs Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Add ui test that fails to compile Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to specify a multiaddress for listening, and listening on multiple addresses at once by passing the option multiple times.
Right now only the
/ip4/.../tcp/...,/ip6/.../tcp/..., and.../wsschemes are supported in substrate.This makes the
--portoption a bit redundant. I kept it for backward compatibility, but we ideally it would be removed.