Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix wasm executor compile error #631

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

woodsmur
Copy link
Contributor

No description provided.

@pepyakin
Copy link
Contributor

pepyakin commented Aug 30, 2018

This actually very weird! We don't invoke rust-lld explicitly in any way and it should be an implementation details of the rust toolchain, so rustup should include lld and all libraries as part of the installation. And as far as I can tell, no additional installation steps are required for macOS and Linux environments.

Can you tell me more about your environment? Have you tried to reinstall rust?

@woodsmur
Copy link
Contributor Author

I'm just using the comics vagrant box.

@pepyakin
Copy link
Contributor

Ok, this is surfaced with the latest nightly. Seems like a transient issue.

@pepyakin
Copy link
Contributor

Should be fixed in the next nightly.

@pepyakin pepyakin closed this Aug 31, 2018
@gavofyork gavofyork reopened this Aug 31, 2018
@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A4-gotissues labels Aug 31, 2018
@gavofyork gavofyork merged commit 7c18bb6 into paritytech:master Aug 31, 2018
gavofyork added a commit that referenced this pull request Aug 31, 2018
gguoss pushed a commit to chainx-org/substrate that referenced this pull request Sep 3, 2018
dvdplm added a commit that referenced this pull request Sep 3, 2018
…rs-generic-over-hasher-and-rlpcodec

* origin/master: (26 commits)
  Contract runtime polishing (#601)
  WIP on chain heap (#639)
  Events to track extrinsic success (#640)
  Install llvm-tools-preview component (#643)
  fix wasm executor compile error (#631)
  random fixes (#638)
  Empty becomes (), reflecting convention (#637)
  Allow to build_upon skipped entries, but don't walk back (#635)
  Separate out staking module into balances and payment (#629)
  Update .gitlab-ci.yml (#633)
  Do not attempt to rustup if in CI. This is taken care of by the base (#621)
  Avoid need for ident strings in storage (#624)
  rename to panic_handler as panic_implementation is deprecated in nightly (#626)
  5 random fixes (#2) (#623)
  fix one typo in README (#627)
  Misspelled words (#625)
  Contracts: Per block gas limit (#506)
  Make sure to ban invalid transactions. (#615) (#620)
  Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619)
  Allow specifying listening multiaddresses (#577)
  ...
dvdplm added a commit that referenced this pull request Sep 4, 2018
* master: (22 commits)
  Introduce treasury and document (#646)
  Off-the-table staking preference (#656)
  Implement function `json_metadata` in `decl_module!` (#654)
  Fix warnings in networking (#652)
  Add a reputation system (#645)
  Check for pruned block state (#648)
  Contract runtime polishing (#601)
  WIP on chain heap (#639)
  Events to track extrinsic success (#640)
  Install llvm-tools-preview component (#643)
  fix wasm executor compile error (#631)
  random fixes (#638)
  Empty becomes (), reflecting convention (#637)
  Allow to build_upon skipped entries, but don't walk back (#635)
  Separate out staking module into balances and payment (#629)
  Update .gitlab-ci.yml (#633)
  Do not attempt to rustup if in CI. This is taken care of by the base (#621)
  Avoid need for ident strings in storage (#624)
  rename to panic_handler as panic_implementation is deprecated in nightly (#626)
  5 random fixes (#2) (#623)
  ...
gavofyork added a commit that referenced this pull request Sep 5, 2018
dvdplm added a commit that referenced this pull request Sep 5, 2018
* master:
  Revert "Install llvm-tools-preview component (#643)" (#644)
  Revert "fix wasm executor compile error (#631)" (#642)
  Fetch parity-common dependencies from crates (#617)
  limit retry count in OnDemand (#513)
  Minor refactor for staking module (#659)
dvdplm added a commit that referenced this pull request Sep 5, 2018
…and-rlpcodec

* master:
  Revert "Install llvm-tools-preview component (#643)" (#644)
  Revert "fix wasm executor compile error (#631)" (#642)
  Fetch parity-common dependencies from crates (#617)
  limit retry count in OnDemand (#513)
  Minor refactor for staking module (#659)
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants