This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
reschedule #6860
Merged
reschedule #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
added
A0-please_review
danforbes
reviewed
Aug 12, 2020
Co-authored-by: Dan Forbes <dan@danforbes.dev>
| Ok(()) | ||
| })?; | ||
|
|
||
| let new_index = Agenda::<T>::decode_len(new_time).unwrap_or(1) as u32 - 1; |
There was a problem hiding this comment.
Its more efficient to get the length from the try_mutate above right?
There was a problem hiding this comment.
Agenda::<T>::append was used which doesn't decode the whole thing, it does have the length info but not exposed
gui1117
reviewed
Aug 14, 2020
gui1117
previously requested changes
Aug 14, 2020
There was a problem hiding this comment.
rescheduling to same time ends up removing the task: https://github.com/paritytech/substrate/pull/6860/files#r470499784 (fixed)
gui1117
approved these changes
Aug 17, 2020
|
Good to merge or still need approval from @gavofyork ? |
|
should this needs audit ? |
gavofyork
added
the
D9-needsaudit 👮
|
yes. at this point anything that touches the polkadot runtime needs an audit. |
gavofyork
approved these changes
Aug 19, 2020
gnunicorn
added
A8-mergeoncegreen
and removed
A0-please_review
|
Any updates? |
|
It is in queue for being Audited, but not yet complete. |
|
We are done with the review for this PR - looks good to us! |
shawntabrizi
added
D1-audited 👍
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 9, 2020
…up-updates * master: Async keystore + Authority-Discovery async/await (#7000) Fixes logging of target names with dashes (#7281) seal: Add automated weights for contract API calls (#7017) add ss58 id for nodle (#7279) Refactor CurrencyToVote (#6896) bump-allocator: document & poison (#7277) Reset flaming fir network (#7274) reschedule (#6860) Drop system cache for trie benchmarks (#7242) client: improve log formatting (#7272) Rework `InspectState` (#7271) SystemOrigin trait (#7226) Update ss58 registry for Dock network (#7263) .maintain/monitoring: Add alert when continuous task ends (#7250) Rename `TRANSACTION_VERSION` to `EXTRINSIC_VERSION` (#7258) Split block announce processing into two parts (#6958) Fix offchain election to respect the weight (#7215)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6774
Did not add dispatchable calls because we don't need it. Happy to add it if people wants it.
TODOs: