This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Don't panic on a sink error #7666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A2-insubstantial
ordian
approved these changes
Dec 3, 2020
ordian
reviewed
Dec 3, 2020
| @@ -215,7 +215,7 @@ impl<P, Client> AuthorApi<TxHash<P>, BlockHash<P>> for Author<P, Client> | |||
| Ok(watcher) => { | |||
| subscriptions.add(subscriber, move |sink| { | |||
| sink | |||
| .sink_map_err(|_| unimplemented!()) | |||
| .sink_map_err(|e| log::debug!("Subscription sink failed: {:?}", e)) | |||
There was a problem hiding this comment.
The other logs in the crate also don't use any target 🙈
But I also don't have a better target than the automatic sc_rpc. I could just come up with sc-rpc 🙈
There was a problem hiding this comment.
Let's do this in another PR if we really want it. None of the RPC logging calls in client/rpc have any target set (I checked), so if we want to change this we should update all of them.
gww-parity
approved these changes
Dec 3, 2020
andresilva
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.