This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Return number of keys removed when calling storage_kill on child trie
#8166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
commented
Feb 21, 2021
shawntabrizi
added
B7-runtimenoteworthy
C1-low
athei
suggested changes
Feb 21, 2021
athei
approved these changes
Feb 22, 2021
bkchr
approved these changes
Feb 22, 2021
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot merge force |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the information provided when calling
storage_killon a child trie.Now, in addition to returning a boolean on whether all the data in the child trie has been successfully removed, we also return a
u32value which conveys the actual number of keys that were removed in the process.This is relevant for weight refunds. For example, a
storage_killcall could have a limit of 100, but only 50 items are in the trie. We can charge up front for 100 storage removals, but then return that only 50 were actually removed, and refund any of the extra weight.Relevant for Crowdloans in Polkadot: paritytech/polkadot#2294
polkadot companion: paritytech/polkadot#2488