This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Generate storage info for pallet authority_discovery #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 15, 2021 15:25
Implementing issue #8629
|
User @georgesdib, please sign the CLA here. |
added 4 commits
July 25, 2021 06:50
Need this without full_crypto to be able to add generate_store_info
shawntabrizi
added
B7-runtimenoteworthy
C1-low
shawntabrizi
reviewed
Aug 1, 2021
shawntabrizi
reviewed
Aug 1, 2021
added 2 commits
August 1, 2021 18:45
Can happen if vec size is too large, so truncate the vec in that case
shawntabrizi
reviewed
Aug 1, 2021
|
aura refactoring is also done in this PR #9371 Maybe this PR can only do authority_discovery |
added 2 commits
August 22, 2021 18:46
This is already being addressed by PR #9371
georgesdib
changed the title
Removed any code change in pallet aura to reflect that fact. |
gui1117
reviewed
Aug 25, 2021
There was a problem hiding this comment.
I think it is better to use WeakBoundedVec:
- a correctly configured chain should never reach the bound
- an incorrectly configured chain probably prefer a slight underestimate of PoV with a warning than a truncation of authorities which can have some unexpected result.
More robust implementation following @thiolliere recommendation.
gui1117
approved these changes
Aug 26, 2021
KiChjang
reviewed
Aug 27, 2021
KiChjang
approved these changes
Aug 30, 2021
KiChjang
added
A0-please_review
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of paritytech/polkadot-sdk#323
Refactor Authority Discovery to use WeakBoundedVec instead of Vec.
Polkadot companion paritytech/polkadot#3517