Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make choosing an executor (native/wasm) an explicit part of service construction #9525

Merged
merged 20 commits into from
Aug 18, 2021
Merged

Make choosing an executor (native/wasm) an explicit part of service construction #9525

merged 20 commits into from
Aug 18, 2021

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Aug 9, 2021 •
edited
Loading

Polkadot companion: paritytech/polkadot#3615

@expenses expenses added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 9, 2021
@expenses
Copy link
Contributor Author

Fully closes #9475 .

@expenses expenses mentioned this pull request Aug 10, 2021
Merged
@expenses expenses removed the A3-in_progress Pull request is in progress. No review needed at this stage. label Aug 13, 2021
@expenses expenses requested a review from chevdor August 17, 2021 13:41
@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 17, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 17, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 17, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@expenses expenses requested review from cecton and insipx August 18, 2021 07:03
@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 18, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Benchmarking and Weights' does not match any projects in substrate's Process.json

@expenses
Copy link
Contributor Author

Fuck it

@expenses expenses merged commit 3c2b267 into master Aug 18, 2021
@expenses expenses deleted the ashley-executor-service-stuff branch August 18, 2021 12:26
@expenses expenses moved this from In progress to Done in 🧬✨ – Client Improvements Aug 23, 2021
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@gilescope gilescope gilescope approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@cecton cecton Awaiting requested review from cecton

@insipx insipx Awaiting requested review from insipx

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
No open projects
🧬✨ – Client Improvements
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@expenses @chevdor @gilescope