Add methods param for RPC state_traceBlock

[koushiro]

Signed-off-by: koushiro koushiro.cqx@gmail.com

Summary

Add methods param for RPC state_traceBlock to fetch all changed storages for a given block.

Close #9632

Example

curl \
  -H "Content-Type: application/json" \
  -d '{"id":1, "jsonrpc":"2.0", "method": "state_traceBlock", "params": ["0x0268dff7aa545d493e4640871bcdbb43a09240e5fb3efb91d9900782cabaed35", "f0c365c3cf59d671eb72da0e7a4113c4", "Put"]}' \
  http://localhost:9933

{
  "jsonrpc": "2.0",
  "result": {
    "blockTrace": {
      "blockHash": "08cba31b585b97feb68357fe1b6ca11de2335c346b41abfcbfb6a2667fbfd696",
      "events": [
        {
          "data": {
            "stringValues": {
              "ext_id": "d515",
              "key": "f0c365c3cf59d671eb72da0e7a4113c49f1f0515f462cdcf84e0f1d6045dfcbb",
              "method": "Put",
              "value": "Some(003b9e8b7b010000)",
              "value_encoded": "01003b9e8b7b010000"
            }
          },
          "parentId": null,
          "target": "state"
        },
        {
          "data": {
            "stringValues": {
              "ext_id": "d515",
              "key": "f0c365c3cf59d671eb72da0e7a4113c4bbd108c4899964f707fdaffb82636065",
              "method": "Put",
              "value": "Some(01)",
              "value_encoded": "0101"
            }
          },
          "parentId": null,
          "target": "state"
        },
        {
          "data": {
            "stringValues": {
              "ext_id": "d515",
              "key": "f0c365c3cf59d671eb72da0e7a4113c4bbd108c4899964f707fdaffb82636065",
              "method": "Put",
              "value": "None",
              "value_encoded": "00"
            }
          },
          "parentId": null,
          "target": "state"
        }
      ],
      "methods": "Put",
      "parentHash": "8f193718adebc9de5bab580d0ecc0ac0cc66abb730e487e1fd3cd65ca8855349",
      "spans": [],
      "storageKeys": "f0c365c3cf59d671eb72da0e7a4113c4",
      "tracingTargets": "state"
    }
  },
  "id": 1
}

[emostov]

Looks reasonable to me

[dvdplm]

lgtm, modulo a few questions and suggestions.

[dvdplm]

What happens if the caller specifies both storage_keys and methods? Is there a priority? Or Invalid Params error (this would be my preference)? Either way it'd be good to document the behaviour.

[dvdplm]

Dumb question: what is the expected format of these methods? Is it the Rust name or some other convention (JS?)? A short example here would be valuable to newcomers I think.

[koushiro]

What happens if the caller specifies both storage_keys and methods? Is there a priority?

I prefer the priority of filter conditions to be determined according to the order of declaration of rpc parameters. (Currently, storage_keys is filtered first, then methods)

what is the expected format of these methods?

These methods are just ordinary string format, you could find these methods by rg "method = " primitives/state-machine/src/ext.rs

A short example here would be valuable to newcomers I think.

Yes, I will add a simple example into doc

[dvdplm]

I prefer the priority of filter conditions to be determined according to the order of declaration of rpc parameters. (Currently, storage_keys is filtered first, then methods)

Fair. Can you document that behaviour please?

[dvdplm]

I wonder if this empty string business is going to come back and bite us one day. Ideally we'd have an Option<String> here, but I understand why you went with the same we had before.

[dvdplm]

👍

[emostov]

bot merge

[ghost]

Trying merge.