This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
--dev implies --tmp
#9938
Merged
--dev implies --tmp
#9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `--dev` to imply `--tmp` when no explicit `--base-path` is provided.
bkchr
added
A2-insubstantial
shawntabrizi
approved these changes
Oct 5, 2021
sorpaas
approved these changes
Oct 5, 2021
|
this is a breaking change to developers. |
sorpaas
added
B3-apinoteworthy
and removed
B0-silent
KiChjang
approved these changes
Oct 5, 2021
|
@xlc I will scan the devhub for any issues this may cause - anything else that should be done you think to ensure this is accounted for? I could imagine that some automated testing/CI might rely on the dev DB to remain between runs. I am not aware of any like this offhand though. |
|
I am good as long as this is included in the release notes and we have docs about how to persistent data if people want to. I personally rely on this behavior because otherwise there could be lot of setup required to test some functionality. |
gilescope
approved these changes
Oct 6, 2021
apopiak
reviewed
Oct 6, 2021
apopiak
reviewed
Oct 6, 2021
bkchr
added
B5-clientnoteworthy
C1-low
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
19 tasks
7 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
--devto imply--tmpwhen no explicit--base-pathis provided.