Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events sub #126

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Events sub #126

merged 5 commits into from
Jun 25, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Jun 22, 2020

When subscribing to events there are two common use cases:

  • Finding events emitted after submitting an extrinsic
  • Subscribing to a specific event

This makes it easier to subscribe to a specific event.

@ascjones would it be possible to create a new release after this? Looks like we have all we need for sunshine-identity for now.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Jun 22, 2020

Test failure is spurious

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once merged I will do a release

client/src/lib.rs Outdated Show resolved Hide resolved
client/src/lib.rs Outdated Show resolved Hide resolved
client/src/lib.rs Outdated Show resolved Hide resolved
src/rpc.rs Outdated Show resolved Hide resolved
src/frame/balances.rs Show resolved Hide resolved
@ascjones
Copy link
Contributor

Build is failing

@ascjones ascjones merged commit 7f08471 into paritytech:master Jun 25, 2020
@ascjones ascjones mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants