Expose the rpc client in Client #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we build a `Client` for a substrate chain, we can only access the methods exposed in `Client` which does not cover all the RPC interfaces in the chain, it's not feasible to request the methods like `chain_getKeys` with `Client` only. The downstream user of this library has to build another `RpcClient` for the uncovered RPC interfaces, which can be unneccessary.
|
User @liuchengxu, please sign the CLA here. |
…into expose-rpc-client
|
Ping @ascjones |
ascjones
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the life of the downstream user easier.
With
Client, we can only access the public methods exposed in itbut that does not cover all the RPC interfaces provided by the chain.
Therefore, the user of this library has to build another
RpcClientforthe uncovered RPC interfaces, which can be unnecessary.