-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update jsonrpsee 0.2.0 #285
Conversation
where | ||
T: DeserializeOwned, | ||
{ | ||
match sub.next().await { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a breaking change in jsonrpsee
before all failures were ignored and this would only return on valid responses on the subscription stream
.
We could change this API in subxt
to send back the error here but I didn't want to make any breaking changes.
This error should only occur if the server doesn't send back a response on the stream that is the type T
on the subscription.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* deps: update jsonrpsee 0.2.0 The motivation is to avoid pinning certain alpha versions and to avoid breaking users builds without having to some `Cargo.lock` updating. * cargo fmt * fix tests * fix a few clippy lints * cargo fmt
* Reorg the order of deps (paritytech#284) * Reorg the order of deps This patch is simply for easier editor operation when replacing the substrate deps. * . * deps: update jsonrpsee 0.2.0 (paritytech#285) * deps: update jsonrpsee 0.2.0 The motivation is to avoid pinning certain alpha versions and to avoid breaking users builds without having to some `Cargo.lock` updating. * cargo fmt * fix tests * fix a few clippy lints * cargo fmt * Update substrate * update version * update version * update version * deps: update jsonrpsee 0.3.0 (paritytech#289) Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * Add NextKeys and QueuedKeys for session module (paritytech#291) * Add NextKeys and QueuedKeys for session module * Fix fmt * for darwinia * fix test, use `RuntimeMetadata::V13` Co-authored-by: Liu-Cheng Xu <xuliuchengxlc@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Aki Wu <wuminzhe@gmail.com> Co-authored-by: Greg Hill <gregorydhill@outlook.com>
The motivation is to avoid pinning certain alpha versions and to avoid
breaking users builds without having to some
Cargo.lock
updating.I had to add the
tokio1 compat
flag toasync-std
in order to because we don't useasync-std
anymore injsonrpsee