-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release checklist #418
Conversation
Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
…into jsdw-release-checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample script needs fixing up. I think the order needs fixing and the --dry-run
s need removing. I know it is hard to test this without doing an actual release.
Co-authored-by: Andrew Jones <ascjones@gmail.com>
RELEASING.md
Outdated
(cd codegen && cargo publish) && \ | ||
sleep 5 && \ | ||
(cd macro && cargo hack publish --no-dev-deps --allow-dirty) && \ | ||
sleep 5 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience it sometimes takes more than 5sec, so maybe bump this to 10?
…into jsdw-release-checklist
* Add release checklist * Subxt, not Soketto * more Soketto -> Subxt fixes * Signed tags and note about incrementing version of each crate Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> * Add command to publish crates in required order * undo test breakages and codegen first since macro depends on it * Update RELEASING.md Co-authored-by: Andrew Jones <ascjones@gmail.com> * sleep 10, and text niggles Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Andrew Jones <ascjones@gmail.com>
This is essentially a clone of our Soketto release checklist with a couple of tiny tweaks, so anybody with familiarity releasing Soketto will be familiar with this process too.