Add release checklist #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
reviewed
Feb 1, 2022
niklasad1
reviewed
Feb 1, 2022
Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
…into jsdw-release-checklist
ascjones
reviewed
Feb 1, 2022
Co-authored-by: Andrew Jones <ascjones@gmail.com>
dvdplm
approved these changes
Feb 2, 2022
RELEASING.md
Outdated
| (cd codegen && cargo publish) && \ | ||
| sleep 5 && \ | ||
| (cd macro && cargo hack publish --no-dev-deps --allow-dirty) && \ | ||
| sleep 5 && \ |
There was a problem hiding this comment.
In my experience it sometimes takes more than 5sec, so maybe bump this to 10?
…into jsdw-release-checklist
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* Add release checklist * Subxt, not Soketto * more Soketto -> Subxt fixes * Signed tags and note about incrementing version of each crate Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> * Add command to publish crates in required order * undo test breakages and codegen first since macro depends on it * Update RELEASING.md Co-authored-by: Andrew Jones <ascjones@gmail.com> * sleep 10, and text niggles Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Andrew Jones <ascjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a clone of our Soketto release checklist with a couple of tiny tweaks, so anybody with familiarity releasing Soketto will be familiar with this process too.