Substitute BTreeMap/BTreeSet generated types for Vec #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Feb 21, 2022
Good point! And yup if I thought it would be this straightforward I would have done it first and avoided the previous hack! |
ascjones
approved these changes
Feb 21, 2022
icodezjb
pushed a commit
to chainx-org/substrate-subxt
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we hit an issue (#454) where a key type given to a BTreeMap did not impl Ord, leading to compile errors attempting to use the generated code.
This PR impls @ascjones's suggestion in #456 and makes types that would have been decoded into BTreeMap/BTreeSet instead decode to
Vec<(K,V)>orVec<K>. Since Vecs don't require their contents to impl any particular traits, this avoids such issues, while still preserving the decode order.Closes #456 and #315