Move test crates into a "testing" folder and add a ui (trybuild) test and ui-test helpers #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2022
|
This will fail until #565 is merged in (as one of the tests is for that failure), but is good to go otherwise. |
TarikGul
reviewed
Jun 16, 2022
TarikGul
reviewed
Jun 16, 2022
testing/ui-tests/src/utils/mod.rs
Outdated
| pub use metadata_test_runner::MetadataTestRunner; | ||
|
|
||
| /// Given some pallet metadata, generate a [`RuntimeMetadataPrefixed`] struct. | ||
| /// We default to a duff extrinsic type, and register a fake `DispatchError` type |
There was a problem hiding this comment.
Whoops; british slang maybe?! (Every chance I just made it up/misused it too). I just mean that it's no good/made up/naff! I'll tweak the wording!
There was a problem hiding this comment.
:) That's awesome to know. TIL: Duff.
lexnv
approved these changes
Jun 16, 2022
lexnv
reviewed
Jun 16, 2022
testing/ui-tests/Cargo.toml
Outdated
| @@ -0,0 +1,15 @@ | |||
| [package] | |||
| name = "ui-tests" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Nit: should we keep in sync with ?
name = "subxt-integration"
version = "0.21.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testingfolder to avoid polluting the root too much with test bits.ui-testscrate with utils to make it easier to generate metadata and usetrybuildto check that it compiles properly (or not).