Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Config::Extrinsic Send #681

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Make Config::Extrinsic Send #681

merged 1 commit into from
Oct 7, 2022

Conversation

Wizdave97
Copy link
Contributor

@Wizdave97 Wizdave97 commented Oct 6, 2022 •
edited
Loading

This fixes the future is not Send as this value is used across an await error when calling TxInBlock::wait_for_success
Current Error I get when I call that function
image

@Wizdave97
Copy link
Contributor Author

Wizdave97 commented Oct 6, 2022 •
edited
Loading

@ascjones @jsdw Please take a look

jsdw
jsdw approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this; basically every other type is Send anyway, and it shouldn't be an added burden!

Thanks for the commit!

@ascjones ascjones merged commit 51179a8 into paritytech:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wizdave97 @ascjones @jsdw