Add chainHead RPC methods
#766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Jan 11, 2023
jsdw
reviewed
Jan 11, 2023
There was a problem hiding this comment.
This looks great to me offhand!
One thing I'd suggest I think is to add a few integration tests to call these methods and ensure that they actually work: given that they may be around a while until we are fully using them, it'd be good to ensure that they keep working incase anything changes in the (unstable) API in the meantime :)
Co-authored-by: James Wilson <james@jsdw.me>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
approved these changes
Jan 16, 2023
niklasad1
reviewed
Jan 18, 2023
niklasad1
reviewed
Jan 18, 2023
| /// When the user is no longer interested in a block, the user is responsible | ||
| /// for calling the [`chainhead_unstable_unpin`](Rpc::chainhead_unstable_unpin) method on each. | ||
| /// Failure to do so will result in the subscription being dropped by the chain. | ||
| pub async fn chainhead_unstable_follow( |
There was a problem hiding this comment.
could be nice to have a separate module or something for the v2 impls but perhaps _unstable is sufficient
There was a problem hiding this comment.
In the longer run, hopefully we will be able to remove all of the "old" methods and only have these new ones on this Rpc type :)
niklasad1
approved these changes
Jan 18, 2023
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the low level
chainHeadinterface exposed by the substrate nodes.The
chianHeadfamily of functions is added to subxt's RPC methods, together with the corresponding events required for interpreting the data of the RPC methods.This PR takes the essential parts of #762 PR to aim towards a mergeable form.
Part of #732.