Try to remove Instruction::branch_{i32,i64}_{nez,eqz}
#800
Labels
cleanup
Cleans up some region of the codebase.
register-machine
A work item for the register-machine engine.
With recent refactoring and improvements to the register-machine
wasmi
engine we ended up havingInstruction::branch_i32_eqz
Instruction::branch_i32_nez
Instruction::branch_i64_eqz
Instruction::branch_i64_nez
Which are superseeded by the also existing:
Instruction::branch_i32_eq_imm16
Instruction::branch_i32_ne_imm16
Instruction::branch_i64_eq_imm16
Instruction::branch_i64_ne_imm16
The only downside is that the latter 4 instructions cannot deal with 32-bit
BranchOffset
and use a 16-bitBranchOffset
instead, however, given that I have not yet encountered a single Wasm program that even comes close to approach this limit I think it is okay to ditch reliance on 32-bitBranchOffset
.Removing the 4 superseeded instructions would clean up the engine a bit.
The text was updated successfully, but these errors were encountered: