Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[V Rising (Vanilla)] Secrets of Gloomrot Update #2260

Merged
merged 1 commit into from
May 18, 2023
Merged

[V Rising (Vanilla)] Secrets of Gloomrot Update #2260

merged 1 commit into from
May 18, 2023

Conversation

lilkingjr1
Copy link
Collaborator

Description

  • Adds support for new settings in ServerHostSettings.json, including: ListOnSteam, ListOnEOS, CompressSaveFiles, and API Enabled.
  • Changes stop command to accommodate latest Wings version by force-stopping the server. This is not ideal, but utilizing the current image with eval OR exec (I tested it) still does not seem to pass the SIGINT correctly (or maybe it does and WINE just doesn't listen; I don't know).
  • Improved [SYSTEM] startup parameters.
  • Updated the install script to check for successful installation and use the default ServerHostSettings.json that ships with the server.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

- Adds support for new settings in ServerHostSettings.json, including: ListOnSteam, ListOnEOS, CompressSaveFiles, and API Enabled.
- Changes stop command to accommodate latest Wings version by force-stopping the server. This is not ideal, but utilizing the current image with `eval` OR `exec` (I tested it) still does not seem to pass the SIGINT correctly (or maybe it does and WINE just doesn't listen; I don't know).
- Improved [SYSTEM] startup parameters.
- Updated the install script to check for successful installation and use the default ServerHostSettings.json that ships with the server.
Copy link
Contributor

@gOOvER gOOvER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Egg works like charm.

  • Server install without errors
  • Server starts
  • Server visible in Serverlist
  • can connect to the server

Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintenQVD0 QuintenQVD0 merged commit 5d97c42 into pelican-eggs:master May 18, 2023
@lilkingjr1 lilkingjr1 deleted the v-rising branch May 18, 2023 14:06
@AeonLucid
Copy link

I noticed you added the option API.Enabled. Do you have some information on what this enables?

@lilkingjr1
Copy link
Collaborator Author

lilkingjr1 commented May 21, 2023

Not really... I just saw that it was a new option added to the game's default config file.

Closest thing I could find is this:
https://www.reddit.com/r/vrising/comments/ux1a4v/public_api_update_for_vrising/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants