Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous Features #145

Merged
merged 30 commits into from
Oct 26, 2016
Merged

Numerous Features #145

merged 30 commits into from
Oct 26, 2016

Conversation

tony-gaia
Copy link
Contributor

@tony-gaia tony-gaia commented Oct 26, 2016

  • #1958 Species in returns
    When a field is 'tagged' as a species field in the schema of the ReturnType:
  • the return form will provide a type-ahead feature similar to the species field in application.
  • if the form is pre-filled with species values (like after a an xlsx upload or a curate form), it provides a basic validation. The species field text will turn green if the name is valid.

Note: see the comment in the kanboard ticket on how to 'tag' a species field in the Return Type schema.

  • Added help text as a licence (extracted) field.
    Fixed bug with user account editing not saving.
  • 1960 Add security on Return API

As discussed the API does't implement any Authentication mechanism other than the sessionId

  • 2148 Missing fields in the report payment

  • Product codes with variants now seperate with space
  • Changed 'from Jim Sharp' to 'for Jim Sharp'
  • Clear application data if selecting new licence type.
  • Fix tests to run with -k by using dynamic fixture to create the Country AU

This change is Reviewable

serge-gaia and others added 30 commits October 21, 2016 12:14
UI works exactly like the UI for application field.
TODO: Validation when importing from XLS. Should provide some visual cue about the species being valid or not.
Fixed spelling error
Fixed bug with user account editing not saving.
Added help text as a licence (extracted) field.
…m Sharp' to 'for Jim Sharp'

Clear application data if selecting new licence type.
Product codes with variants now seperate with space,
@wilsonc86
Copy link
Contributor

:lgtm:


Reviewed 7 of 8 files at r1, 4 of 5 files at r2, 4 of 5 files at r3, 2 of 2 files at r4, 7 of 7 files at r5, 5 of 5 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dbca-asi dbca-asi merged commit 3331f47 into dbca-wa:master Oct 26, 2016
@coveralls
Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage increased (+1.9%) to 54.295% when pulling 3982917 on gaiaresources:master into 98f32ee on parksandwildlife:master.

dbca-asi pushed a commit that referenced this pull request Mar 1, 2017
Added ability to assign an assessment to a particular assessor.
dbca-asi pushed a commit that referenced this pull request Mar 25, 2019
Wildlifecompliance merge latest from dbca-dragon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants