Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with the handling of bodyType in the bodies methods #76

Closed
mottihoresh opened this issue Jun 10, 2024 · 1 comment
Closed

Comments

@mottihoresh
Copy link

mottihoresh commented Jun 10, 2024

I have been playing around with setting the heat on and off, and I've discovered that the bodies.setHeatModeAsync does not work properly. it will only accept BodyIndex.SPA or BodyIndex.POOL which are either 1 or 0.

The bodies.setHeatModeAsync then calls the sendHeatModeMessage, unlike the two other methods sendCoolSetPointMessage and sendSetPointMessage the sendHeatModeMessage deducts 1 form the bodyType value. essentially, when using BodyIndex.SPA the data is set against the POOL, and it's impossible to set the SPA heat mode directly unless you call the sendHeatModeMessage method directly.

The following:

    client.bodies.setHeatModeAsync(BodyIndex.POOL, HeatModes.HEAT_MODE_HEATPUMP);
    client.bodies.setHeatModeAsync(BodyIndex.SPA, HeatModes.HEAT_MODE_HEATPUMP);

essentially translates to:

    client.controller.bodies.sendHeatModeMessage(-1, 3)
    client.controller.bodies.sendHeatModeMessage(0, 3)
@mottihoresh mottihoresh changed the title Inconsistencies with the handling of bodyType in the bodies method Inconsistencies with the handling of bodyType in the bodies methods Jun 10, 2024
@parnic
Copy link
Owner

parnic commented Jun 11, 2024

Thanks for the report, I'll take a look.

@parnic parnic closed this as completed in 517ab1d Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants