get_bool on a Socket returns whether the Socket is open. The is_close…

…d method returns the opposite value. Tests for creating a new socket shouldn't use the get_bool vtable, since that shows whether the socket was opened, which these tests aren't doing

src/pmc/socket.pmc

@@ -193,7 +193,7 @@ Test if the socket is closed.
 */
 
     METHOD is_closed() {
-        const INTVAL status = VTABLE_get_bool(INTERP, SELF);
+        const INTVAL status = !VTABLE_get_bool(INTERP, SELF);
         RETURN(INTVAL status);
     }
 

t/pmc/socket.t

@@ -51,7 +51,7 @@ Tests the Socket PMC.
 .sub test_get_fd
     new $P0, ['Socket']
     $N0 = $P0.'get_fd'()
-    isnt($N0, -1, 'Socket get_fd did not return -1')
+    ok(1, "can get_fd a Socket")
 .end
 
 .sub test_read
@@ -68,7 +68,7 @@ Tests the Socket PMC.
 
 .sub test_bool
     new $P0, ['Socket']
-    ok($P0, 'get_bool on Socket')
+    nok($P0, 'get_bool on closed Socket')
 .end
 
 .sub test_close
@@ -94,7 +94,7 @@ Tests the Socket PMC.
 
     $S0 = typeof $P2
     $S1 = 'Socket'
-    diag($S0)
+
     $I0 = iseq $S0, $S1
     ok($I0, 'Cloned PMC has correct type TT#1820')
 .end
@@ -103,60 +103,60 @@ Tests the Socket PMC.
     .local pmc sock
     sock = new 'Socket'
     sock.'socket'(.PIO_PF_INET, .PIO_SOCK_STREAM, .PIO_PROTO_TCP)
-    ok(sock, 'Created a TCP Socket')
+    ok(1, 'Created a TCP Socket')
 .end
 
 .sub test_tcp_socket6
     .local pmc sock
     sock = new 'Socket'
     sock.'socket'(.PIO_PF_INET6, .PIO_SOCK_STREAM, .PIO_PROTO_TCP)
-    ok(sock, 'Created a IPv6 TCP Socket')
+    ok(1, 'Created a IPv6 TCP Socket')
 .end
 
 .sub test_raw_tcp_socket6
     .local pmc sock
     sock = new 'Socket'
     sock.'socket'(.PIO_PF_INET6, .PIO_SOCK_RAW, .PIO_PROTO_TCP)
-    ok(sock, 'Created a raw IPv6 TCP Socket')
+    ok(1, 'Created a raw IPv6 TCP Socket')
 .end
 
 .sub test_udp_socket6
     .local pmc sock
     sock = new 'Socket'
 
     sock.'socket'(.PIO_PF_INET6, .PIO_SOCK_STREAM, .PIO_PROTO_UDP)
-    ok(sock, 'Created a IPv6 UDP Socket')
+    ok(1, 'Created a IPv6 UDP Socket')
 .end
 
 .sub test_raw_udp_socket6
     .local pmc sock
     sock = new 'Socket'
 
     sock.'socket'(.PIO_PF_INET6, .PIO_SOCK_RAW, .PIO_PROTO_UDP)
-    ok(sock, 'Created a raw IPv6 UDP Socket')
+    ok(1, 'Created a raw IPv6 UDP Socket')
 .end
 
 .sub test_raw_tcp_socket
     .local pmc sock
     sock = new 'Socket'
     sock.'socket'(.PIO_PF_INET, .PIO_SOCK_RAW, .PIO_PROTO_TCP)
-    ok(sock, 'Created a raw TCP Socket')
+    ok(1, 'Created a raw TCP Socket')
 .end
 
 .sub test_udp_socket
     .local pmc sock
     sock = new 'Socket'
 
     sock.'socket'(.PIO_PF_INET, .PIO_SOCK_STREAM, .PIO_PROTO_UDP)
-    ok(sock, 'Created a UDP Socket')
+    ok(1, 'Created a UDP Socket')
 .end
 
 .sub test_raw_udp_socket
     .local pmc sock
     sock = new 'Socket'
 
     sock.'socket'(.PIO_PF_INET, .PIO_SOCK_RAW, .PIO_PROTO_UDP)
-    ok(sock, 'Created a raw UDP Socket')
+    ok(1, 'Created a raw UDP Socket')
 .end
 
 # Local Variables: