GCI task #7
Closed
GCI task #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no information about how to get git on Windows. You should mention msysgit and tortoisegit at least. You should show some examples for how to check out a particular branch/tag. A major release tag like VERSION_2_0_0 would make a good example. You can show checking out a specific branch with the master branch. Try to follow the formatting and style of the rest of the document for consistency. Thanks |
|
The information about debian is wrong. The package to install is git-core, not "core". Otherwise, we are getting better, thanks. |
|
The last git command is wrong. The second to last command is misleading, since all of history is still downloaded. Best to just mention the basic command and more whitespace is needed, so the commands stand out. The commands should be on their own lines. |
|
This looks better. Just removed the last 2 git commands after "How to fetch from a tag" and this task will be done and will get merged. |
|
Pulled into the new_readme branch for evaluation and integration. Thanks for the hard work, and thanks for taking all our criticisms and requests! |
rurban
pushed a commit
that referenced
this pull request
Dec 12, 2012
Postpone TASK_recv_block_CLEAR(partner) when another task wants to check
!TASK_in_preempt_TEST(_self)
$ tsan ./parrot t/pmc/task.t
==6406== ThreadSanitizer, a data race detector
1..8
ok 1 - initialized
ok 2 task1 ran
ok 3 task2 ran
ok 4 sub1 ran
==6406== INFO: T2 has been created by T0. Use --announce-threads to see the creation stack.
==6406== INFO: T0 is program's main thread
==6406== WARNING: Possible data race during write of size 8 at 0x43A6218: {{{
==6406== T0 (L{L31}):
==6406== #0 Parrot_Task_nci_send /usr/src/parrot/master/src/pmc/task.c:316
==6406== #1 Parrot_NativePCCMethod_invoke /usr/src/parrot/master/src/pmc/nativepccmethod.c:122
==6406== #2 Parrot_callmethodcc_p_sc /usr/src/parrot/master/src/ops/core_ops.c:18300
==6406== #3 runops_fast_core /usr/src/parrot/master/src/runcore/cores.c:499
==6406== #4 runops_int /usr/src/parrot/master/src/runcore/main.c:220
==6406== #5 runops /usr/src/parrot/master/src/call/ops.c:123
==6406== #6 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:338
==6406== #7 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==6406== #8 Parrot_Task_invoke /usr/src/parrot/master/src/pmc/task.c:168
==6406== #9 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:330
==6406== #10 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==6406== #11 Parrot_cx_next_task /usr/src/parrot/master/src/scheduler.c:231
==6406== Concurrent read(s) happened at (OR AFTER) these points:
==6406== T2 (L{}):
==6406== #0 Parrot_Task_invoke /usr/src/parrot/master/src/pmc/task.c:175
==6406== #1 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:330
==6406== #2 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==6406== #3 Parrot_cx_next_task /usr/src/parrot/master/src/scheduler.c:231
==6406== #4 Parrot_thread_outer_runloop /usr/src/parrot/master/src/thread.c:322
==6406== Location 0x43A6218 is 1544 bytes inside a block starting at 0x43A5C10 of size 4096 allocated by T0 from heap:
==6406== #0 calloc /mnt/data/build/slave/full_linux_build/build/tsan/ts_valgrind_intercepts.c:444
==6406== #1 mem_sys_allocate_zeroed /usr/src/parrot/master/src/gc/alloc_memory.c:97
==6406== #2 allocate_new_pool_arena /usr/src/parrot/master/src/gc/fixed_allocator.c:547
==6406== #3 pool_allocate /usr/src/parrot/master/src/gc/fixed_allocator.c:448
==6406== #4 Parrot_gc_pool_allocate /usr/src/parrot/master/src/gc/fixed_allocator.c:344
==6406== #5 gc_gms_allocate_pmc_header /usr/src/parrot/master/src/gc/gc_gms.c:1490
==6406== #6 Parrot_gc_new_pmc_header /usr/src/parrot/master/src/gc/api.c:312
==6406== #7 get_new_pmc_header /usr/src/parrot/master/src/pmc.c:571
==6406== #8 Parrot_pmc_new_init /usr/src/parrot/master/src/pmc.c:630
==6406== #9 Parrot_thread_create_proxy /usr/src/parrot/master/src/thread.c:156
==6406== Locks involved in this report (reporting last lock sites): {L31}
==6406== L31 (0x42F02A8)
==6406== #0 pthread_mutex_lock /mnt/data/build/slave/full_linux_build/build/tsan/ts_valgrind_intercepts.c:935
==6406== #1 Parrot_Task_nci_send /usr/src/parrot/master/src/pmc/task.c:312
==6406== #2 Parrot_NativePCCMethod_invoke /usr/src/parrot/master/src/pmc/nativepccmethod.c:122
==6406== #3 Parrot_callmethodcc_p_sc /usr/src/parrot/master/src/ops/core_ops.c:18300
==6406== #4 runops_fast_core /usr/src/parrot/master/src/runcore/cores.c:499
==6406== #5 runops_int /usr/src/parrot/master/src/runcore/main.c:220
==6406== #6 runops /usr/src/parrot/master/src/call/ops.c:123
==6406== #7 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:338
==6406== #8 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==6406== #9 Parrot_Task_invoke /usr/src/parrot/master/src/pmc/task.c:168
==6406== #10 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:330
==6406== #11 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==6406== Race verifier data: 0x5168EC1,0x516785D
==6406== }}}
ok 5 Got message after block
ok 6 Got existing message
ok 7 task_to_kill running
ok 8 task_to_kill killed
==6406==
==6406== ThreadSanitizer summary: reported 1 warning(s) (1 race(s))
rurban
pushed a commit
that referenced
this pull request
Dec 12, 2012
Racy write with read in Parrot_alarm_check, lock alarm_serial += 1;
$ tsan ./parrot t/pmc/task.t
ok 9 pre-empt and exit
==18766== INFO: T0 is program's main thread
==18766== INFO: T1 has been created by T0. Use --announce-threads to see the creation stack.
==18766== WARNING: Possible data race during write of size 8 at 0x5322580: {{{
==18766== T1 (L{}):
==18766== #0 Parrot_alarm_runloop /usr/src/parrot/master/src/alarm.c:129
==18766== Concurrent read(s) happened at (OR AFTER) these points:
==18766== T0 (L{}):
==18766== #0 Parrot_alarm_check /usr/src/parrot/master/src/alarm.c:154
==18766== #1 Parrot_cx_check_scheduler /usr/src/parrot/master/src/scheduler.c:253
==18766== #2 Parrot_branch_ic /usr/src/parrot/master/src/ops/core_ops.c:13735
==18766== #3 runops_fast_core /usr/src/parrot/master/src/runcore/cores.c:499
==18766== #4 runops_int /usr/src/parrot/master/src/runcore/main.c:220
==18766== #5 runops /usr/src/parrot/master/src/call/ops.c:123
==18766== #6 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:338
==18766== #7 Parrot_ext_call /usr/src/parrot/master/src/extend.c:158
==18766== #8 Parrot_Task_invoke /usr/src/parrot/master/src/pmc/task.c:168
==18766== #9 Parrot_pcc_invoke_from_sig_object /usr/src/parrot/master/src/call/pcc.c:330
==18766== Address 0x5322580 is 0 bytes inside data symbol "alarm_serial"
==18766== Race verifier data: 0x4FEC3AE,0x4FEC3FB
==18766== }}}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed a GCI task (http://www.google-melange.com/gci/task/show/google/gci2010/parrot_perl_foundations/t129061714267)