Update formatter to handle older Elixir versions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18e7b99 updated the formatter to handle ExUnit's `tests_counter` change from an integer to a map in elixir-lang/elixir@c4d6be6#diff-0ed5c47cc55f463c3af34af96d1fef62L18 in a way that wasn't backwards compatible with older Elixir versions. This updates the formatter to handle older Elixir versions by checking whether `tests_counter` is a map and updating it accordingly.
| @@ -13,8 +13,13 @@ defmodule ExCheck.Formatter do | |||
|
|
|||
| @doc false | |||
| def handle_event(event = {:suite_finished, _run_us, _load_us}, config) do | |||
| updated_test_count = config.tests_counter.test + ExCheck.IOServer.total_tests | |||
| new_cfg = %{config | tests_counter: %{test: updated_test_count}} | |||
| updated_test_count = | |||
There was a problem hiding this comment.
IMHO this would be more idiomatic:
# in handle_event
updated_tests_counter = update_tests_counter(config.tests_counter, ExCheck.IOServer.total_tests)
# then, below:
defp update_tests_counter(count, increment) when is_integer(count) do
count + increment
end
defp update_tests_counter(counter, increment) when is_map(counter) do
%{counter | test: counter.test + increment}
end
Ideally you'd find out if tests_counter is a struct and pattern match on that struct.
There was a problem hiding this comment.
I like that approach; it's cleaner and more extensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18e7b99 updated the formatter to handle ExUnit's
tests_counterchangefrom an integer to a map in
elixir-lang/elixir@c4d6be6#diff-0ed5c47cc55f463c3af34af96d1fef62L18
in a way that wasn't backwards compatible with older Elixir versions.
This updates the formatter to handle older Elixir versions by checking
whether
tests_counteris a map and updating it accordingly.