Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter] Filter sensitive data in request url #26

Merged
merged 2 commits into from
Aug 1, 2015

Conversation

gullitmiranda
Copy link
Contributor

There are cases where the url may contain sensitive information, so I made a change to apply the filter also in the request url.

For example, in this case it is necessary to replace the project_id.

[
  {
    "request": {
      // ...
      "url": "https://api.keen.io/3.0/projects/[project_id]/events/start"
    },
    // ...
  }
]

parroty added a commit that referenced this pull request Aug 1, 2015
[filter] Filter sensitive data in `request url`
@parroty parroty merged commit b361e14 into parroty:master Aug 1, 2015
@parroty
Copy link
Owner

parroty commented Aug 1, 2015

Thanks. It addresses #18, correct?

@gullitmiranda
Copy link
Contributor Author

Yes. sorry, I had not looked at the issues. I ended up making the change by necessity itself and decided to submit.
I believe this completely solve the need reported in issue #18.

parroty added a commit that referenced this pull request Aug 1, 2015
@parroty
Copy link
Owner

parroty commented Aug 1, 2015

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants