filter_sensitive_data in query params

[semanticart]

First off: great library, thank you.

I find myself wanting to filter out sensitive data in the query params of a url I'm recording AND still use match_requests_on: [:query]. So basically I want to match on URL but substitute false values for real ones. So I could match a recording with url http://example.com?api_key=FAKE_KEY&page=1 when fetching url http://example.com?api_key=abcdefg&page=1

It would not match a cassette with url http://example.com?api_key=abcdefg&page=SOMETHING_ELSE

Is this feature something you'd adopt? Any advice? I can try to put up a PR, but don't want to waste the time if you wouldn't find it valuable.

[parroty]

Thank you for the comment. I haven't tried this case, but I think it makes sense. If you can come up with PR, that's great.

I don't have clear idea how it should be modified yet (need to check back the code more..). I think the query parameter is not well handled for filter_sensitive_data, and just remove or not at the moment (at around ExVCR.Converter). Updating around this might solve the case?

[parroty]

It would be addressed by #26 and I'm closing at the moment. If you find any issue, please reopen or open another one.