Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processargs exception print is not very useful #1

Open
bdkearns opened this issue Oct 26, 2014 · 1 comment
Open

processargs exception print is not very useful #1

bdkearns opened this issue Oct 26, 2014 · 1 comment

Comments

@bdkearns
Copy link

antlr4 build fails with simply "1.6" printed to console when Java 1.6 isn't present. str(e) just prints the exception args, which in this KeyError case is "1.6", not even really an indication of an error. I'd suggest replacing "print e" with "traceback.print_exc()".

also, this code is idented with tabs. i would have done a pull request but my editor isn't set up to use tabs in python code, and i think you'll find most others expect python indentation with spaces also.

http://legacy.python.org/dev/peps/pep-0008/#tabs-or-spaces

@parrt
Copy link
Owner

parrt commented Oct 26, 2014

Hi. Thanks. Yeah,I've been meaning to get back to this bild system. I started teaching again after two years and so I'm prepping like crazy. I hope to have more time in December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants