Deprecate HHVM workload and Facebook OSS #369
Conversation
| @@ -0,0 +1 @@ | |||
| This image is deprecated in CloudSuite 4 and not maintained by us anymore. However, you can still pull the binary image if you want to run the workload. | |||
There was a problem hiding this comment.
not maintained --> will not be maintained or we will not maintain.
commons/hhvm/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| This image is deprecated in CloudSuite 4 and not maintained by us anymore. However, you can still pull the binary image if you want to run the workload. | |||
There was a problem hiding this comment.
not maintained --> will not be maintained or we will not maintain.
| @@ -1,5 +1,7 @@ | |||
| # Facebook Workload | |||
|
|
|||
| > **Warning:** This benchmark is deprecated in CloudSuite 4 and not maintained anymore. However, you can still download the binary image with the command in this document and run the experiment. | |||
There was a problem hiding this comment.
not maintained --> will not be maintained or we will not maintain.
command --> commands
.github/workflows/build-images.yaml
Outdated
| # DF_PATH: "./commons/${{ github.job }}/${{ matrix.tag }}" | ||
| # DBX_PLATFORM: ${{ matrix.platform }} | ||
| # - id: set_is_parent_modified | ||
| # run: echo "::set-output name=is_parent_modified::${MODIFIED}" |
There was a problem hiding this comment.
If we deprecate the workload, do we need to keep these lines as comments in the script? It makes it ugly and does not serve any purpose if we won't build them again in the future.
.github/workflows/build-images.yaml
Outdated
| # env: | ||
| # IMG_TAG: "${{ matrix.tag }}" | ||
| # DF_PATH: "./benchmarks/${{ github.job }}/${{ matrix.tag }}" | ||
| # DBX_PLATFORM: ${{ matrix.platform }} |
There was a problem hiding this comment.
If we deprecate the workload, do we need to keep these lines as comments in the script? It makes it ugly and does not serve any purpose if we won't build them again in the future.
|
I also suggest that we remove this workload completely from the main branch as everything on the main is considered as supported cloudsuite workloads. We can devote a branch that still holds fb-oss for anyone who wants to have access to it. |
xusine
force-pushed
the
deprecate-hhvm
branch
from
f0b4c2e
to
a24f8e1
Compare
No description provided.