Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for data-analytics #77

Merged
merged 3 commits into from
Feb 6, 2017
Merged

Add scripts for data-analytics #77

merged 3 commits into from
Feb 6, 2017

Conversation

ivonindza
Copy link
Contributor

probably useful for testing on nodes

Copy link
Collaborator

@neo-apz neo-apz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a tests folder. Could you please move your files to there?
It should be cloudsuite/tests/data-analytics/*.

@ivonindza
Copy link
Contributor Author

Well, it's not an automated test. It's just a set of scripts to build the image across nodes, start the master and slaves, and stop them. It could be used to create a test, but it's mainly useful to start things on multiple nodes with a single command.

@neo-apz
Copy link
Collaborator

neo-apz commented Feb 3, 2017

You are right. But we had a discussion with @javpicorel and we decided to have all these kinda things under the tests folder. We'll move the rests of the scripts into another subfolder named travis.

@ivonindza
Copy link
Contributor Author

I moved them to the tests directory, but I still think that's a bad idea. We should have a separate directory for little helper scripts.

@neo-apz
Copy link
Collaborator

neo-apz commented Feb 6, 2017

OK. I guess now it's better.
Now, we have a single scripts folder. Your scripts are there along with the scripts we had for travis ci.

@neo-apz neo-apz merged commit a091c1e into master Feb 6, 2017
@ivonindza ivonindza deleted the scripts branch February 6, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants