Make SetIfDifferent no longer check if a key is mutable.
#41
Conversation
richardjrossiii
force-pushed
the
richardross.installation.fix
branch
from
850b84d
to
d9c44ec
Compare
| SetIfDifferent("appVersion", ParseClient.PlatformHooks.AppBuildVersion); | ||
| SetIfDifferent("appIdentifier", ParseClient.PlatformHooks.AppIdentifier); | ||
| SetIfDifferent("appName", ParseClient.PlatformHooks.AppName); | ||
| ForceSetIfDifferent("deviceType", ParseClient.PlatformHooks.DeviceType); |
There was a problem hiding this comment.
SetIfDifferent will not check for mutability. https://github.com/ParsePlatform/Parse-SDK-dotNET/blob/master/Parse/ParseObject.cs#L1238
I'm not sure this is the right fix.
There was a problem hiding this comment.
It does check for mutability when it calls Remove, though.I guess we can change each of these SetIfDifferentCalls and bound them by a null check on the value, although I'm not certain that makes a ton of sense (we could end up with really stale values).
There was a problem hiding this comment.
I think the correct solution for this would be to refactor SetIfDifferent so that it also forces Remove, and not make another ForceSetIfDifferent. SetIfDifferent by definition should force update.
This would cause issues when updating an installation. By forcing removal of a key using an operation, we no longer check for children who override `IsMutableForKey`. Fixes #40, and probably several others.
richardjrossiii
force-pushed
the
richardross.installation.fix
branch
from
d9c44ec
to
6d76515
Compare
richardjrossiii
changed the title
SetIfDifferent no longer check if a key is mutable.
|
PR updated. |
|
Perfecto |
Make `SetIfDifferent` no longer check if a key is mutable.
This would cause issues when updating an installation. By forcing removal of a key using an operation, we no longer check for children who override
IsMutableForKey.Fixes #40, and probably several others.
cc @grantland @hallucinogen