Logger: Fix timestamp and format #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get non json console loggging by default
timestamps in files
is not filtering on level.
|
closes #5561 |
|
@acinader Looks good to me. Closed/open to force travis to run |
|
fyi, you can just re-run it on travis.
|
|
Oops I didn't see that when you moved from Draft to PR. |
|
well good thing you did! looking at the tests that I thought were fixed... |
becuase we have timestamps.
Codecov Report
@@ Coverage Diff @@
## master #5571 +/- ##
==========================================
- Coverage 94.06% 94.03% -0.03%
==========================================
Files 129 129
Lines 9192 9194 +2
==========================================
Hits 8646 8646
- Misses 546 548 +2
Continue to review full report at Codecov.
|
|
Just tried your fix in the dashboard. It doesn't error anymore
|
dplewis
approved these changes
May 9, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* remove no-op config of logger * add a test to check on the timestamp * add a test to verify that we get non json console loggging by default * configure transports to include timestamps in files * Add failing test to confirm that WinstonLoggerAdapter is not filtering on level. * actually fix the test to refelect the facth that this isn't the problem * Remove bogus date ranges that are now failing becuase we have timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5560
When digging into the failed tests on #5561 I realized that we want to configure each transport, rather than the whole logger.
I also think we have to handle json distinctly, so I started a new branch.
@mrowe009 did the hard work here....