Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Parse Pointer allows to access internal Parse Server classes and circumvent beforeFind query trigger #8734

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 4, 2023

Fixes security vulnerability GHSA-fcv6-fg5r-jm9q.

fix: review

Update src/RestQuery.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

fix: name
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: beta-jm9p fix: Beta-jm9p Sep 4, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 4, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza changed the title fix: Beta-jm9p refactor: beta-jm9p Sep 4, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: beta-jm9p refactor: Beta-jm9p Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 97.70% and project coverage change: -0.02% ⚠️

Comparison is base (d6b17ba) 94.46% compared to head (15b664b) 94.45%.

❗ Current head 15b664b differs from pull request most recent head 307d585. Consider uploading reports for the commit 307d585 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             beta    #8734      +/-   ##
==========================================
- Coverage   94.46%   94.45%   -0.02%     
==========================================
  Files         184      185       +1     
  Lines       14640    14647       +7     
==========================================
+ Hits        13830    13835       +5     
- Misses        810      812       +2     
Files Changed Coverage Δ
src/rest.js 98.63% <95.45%> (-0.24%) ⬇️
src/RestQuery.js 95.70% <97.14%> (-0.14%) ⬇️
src/Auth.js 99.61% <100.00%> (+<0.01%) ⬆️
src/Controllers/PushController.js 97.87% <100.00%> (ø)
src/Controllers/UserController.js 95.91% <100.00%> (ø)
src/RestWrite.js 94.73% <100.00%> (-0.29%) ⬇️
src/SharedRest.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title refactor: Beta-jm9p refactor: Parse Pointer allows to access internal Parse Server classes and circumvent beforeFind query trigger Sep 4, 2023
@mtrezza mtrezza merged commit 739ffbe into parse-community:beta Sep 4, 2023
24 of 26 checks passed
@mtrezza mtrezza deleted the jm9q/fix-beta-jm9q branch September 6, 2023 00:29
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Sep 16, 2023
* beta:
  chore(release): 6.3.0 [skip ci]
  release
  refactor: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger (parse-community#8734)
  chore(release): 6.2.2 [skip ci]
  fix: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger; fixes security vulnerability [GHSA-fcv6-fg5r-jm9q](GHSA-fcv6-fg5r-jm9q)
  refactor: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8677)
  chore(release): 6.2.1 [skip ci]
  fix: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8674)
  refactor: Add option to convert `Parse.Object` to instance in Cloud Function payload (parse-community#8656)
ashish-naik added a commit to ashish-naik/parse-server-FB-signup-error206 that referenced this pull request Sep 19, 2023
* commit 'b1e1bf6708f5d32b2846e66de40f48fb0ec1dc86':
  chore(release): 6.4.0-beta.1 [skip ci]
  release
  chore(release): 6.3.0 [skip ci]
  release
  chore(release): 6.3.0-alpha.9 [skip ci]
  perf: Improve performance of recursive pointer iterations (parse-community#8741)
  refactor: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger (parse-community#8734)
  chore(release): 6.2.2 [skip ci]
  fix: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger; fixes security vulnerability [GHSA-fcv6-fg5r-jm9q](GHSA-fcv6-fg5r-jm9q)
  refactor: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8677)
  chore(release): 6.2.1 [skip ci]
  fix: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8674)
  refactor: Add option to convert `Parse.Object` to instance in Cloud Function payload (parse-community#8656)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants