Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts httpRequest body to string if needed #91

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

natanrolnik
Copy link
Contributor

No description provided.

@natanrolnik
Copy link
Contributor Author

As discussed in #88

@gfosco
Copy link
Contributor

gfosco commented Feb 1, 2016

I saw and merged #105 before this... Both claiming to fix the same issue... Are they both valuable together, or which one is better?

@natanrolnik
Copy link
Contributor Author

From what my JS knowledge allowed, I understand that they are different things. They are similar names but in different locations. Maybe the title of my commit/PR should be changed.

  • Mine takes care of converting the body to string in case it's an object; and we are talking about the httpRequest defined in Parse.Cloud.httpRequest.
  • Parse request.where from string into JSON #105 takes care of the conversion in the where of a find in the handleFind function.

@r4zzz4k
Copy link
Contributor

r4zzz4k commented Feb 1, 2016

I agree, they seem totally unrelated. #105 is about querying objects within current Parse App, and this one is associated with general-purpose HTTP queries from within Cloud Code.

gfosco added a commit that referenced this pull request Feb 1, 2016
Converts httpRequest body to string if needed
@gfosco gfosco merged commit 952ccd4 into parse-community:master Feb 1, 2016
@gfosco
Copy link
Contributor

gfosco commented Feb 1, 2016

👍

montymxb pushed a commit to montymxb/parse-server that referenced this pull request Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants