Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Value to interface, extract functionality to CoreValue and create a NotAValue class #282

Merged
merged 18 commits into from
Feb 16, 2019
Merged

Convert Value to interface, extract functionality to CoreValue and create a NotAValue class #282

merged 18 commits into from
Feb 16, 2019

Commits on Feb 7, 2019

  1. #280: Changed Value into an interface, extracted functionality into C… 

    …oreValue.
    @jvdb
    jvdb committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    f3db1f8 View commit details
    Browse the repository at this point in the history

  2. #280: Moved NOT_A_VALUE from CoreValue back to Value.

    @jvdb
    jvdb committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    9732725 View commit details
    Browse the repository at this point in the history

  3. #280: Created NotAValue class.

    @jvdb
    jvdb committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    34ccd75 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. #280: Replaced reference checks on NOT_A_VALUE with calls to equals().

    @jvdb
    jvdb committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    33d8584 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. #280: Added and adapted unit tests for NotAValue.

    @jvdb
    jvdb committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    5b066d4 View commit details
    Browse the repository at this point in the history

  2. #280: Added missing license header.

    @jvdb
    jvdb committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    0755624 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. #280: Made the NotAValue class final to ensure uniqueness of NOT_A_VA… 

    …LUE.
    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    87e0260 View commit details
    Browse the repository at this point in the history

  2. #70: Added SingleValueExpression interface. Converted size argument o… 

    …f Def to SingleValueExpression, along with all dependencies.
    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    a0699f6 View commit details
    Browse the repository at this point in the history

  3. #70: Converted n argument of RepN to SingleValueExpression, along wit… 

    …h all dependencies.
    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    51c1986 View commit details
    Browse the repository at this point in the history

  4. #70: Converted Expand, Count, CurrentIteration, CurrentOffset, First … 

    …and Self to SingleValueExpression.
    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    b74a111 View commit details
    Browse the repository at this point in the history

  5. #70: Converted the initial argument to the various Fold ValueExpressi… 

    …ons to SingleValueExpression.
    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    d7543b4 View commit details
    Browse the repository at this point in the history

  6. #70: Converted type of SELF in Shorthand.

    @jvdb
    jvdb committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    b731301 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. #70: Resolved variable name shadowing.

    @jvdb
    jvdb committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    a690989 View commit details
    Browse the repository at this point in the history

  2. #70: Converted all Fold operations to SingleValueExpression.

    @jvdb
    jvdb committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    3deb451 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. #70: Handled review comments from @rdvdijk and @ccreeten.

    @jvdb
    jvdb committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    60fedd2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #283 from parsingdata/single-value-expression 

    Add SingleValueExpression to type ValueExpressions that always return a single value
    @jvdb
    jvdb committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    1744fda View commit details
    Browse the repository at this point in the history

  3. #280: Fixed stack trace issue with exceptions thrown from NotAValue b… 

    …ased on @rdvdijk and @ccreeten comments.
    @jvdb
    jvdb committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    b712149 View commit details
    Browse the repository at this point in the history

  4. #280: Renamed and fixed spacing between interface/abstract methods. B… 

    …ased on comments of @rdvdijk and @ccreeten.
    @jvdb
    jvdb committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    6480c62 View commit details
    Browse the repository at this point in the history