-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loader added on encrypt wallet, create wallet, restore wallet and few… #206
Conversation
The RPC state service should not be used for things like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use state service.
I don't see what's wrong with using the state service for this? It is global state |
The state service flattens everything, we have no clue which variables are stored in it and under which names. I don't think it's very smart to use the same state service for our own variables, it will eventually become one big mess where nobody knows what's what. At the very least tag the variable names with something that ensures it doesn't collide with critical variables (such as those returned by the rpc). A better approach imo would be to get rid of the flattening and use a different state for UI/global stuff. |
okay, @vikas-cis please prefix it with |
Sure its done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! Thanks @vikas-cis :D
Prefixed with 'ui:' so that it's clear that its UI related only
… design tweaks