Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of CSS classes to confirmations #454

Merged
merged 4 commits into from
Dec 1, 2017
Merged

Addition of CSS classes to confirmations #454

merged 4 commits into from
Dec 1, 2017

Conversation

vikas-cis-zz
Copy link

@vikas-cis-zz vikas-cis-zz self-assigned this Dec 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 47.904% when pulling 39e7706 on vikas-cis:confirmations_classes into 28a36af on particl:restructure.

AllienWorks
AllienWorks suggested changes Dec 1, 2017
View reviewed changes
src/app/wallet/wallet/shared/transaction-table/transaction-table.component.html Outdated
@@ -28,7 +28,7 @@
<mat-panel-title fxFlex="1 0 50px" fxFlex.lt-md="100" *ngIf="display.confirmations" class="history_confirmation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the dynamic classes to this element instead?

Copy link
Author

@vikas-cis-zz vikas-cis-zz Dec 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah sure, I thought css will be only for confirmation text :P

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllienWorks done please check now

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 47.904% when pulling cd5fbfe on vikas-cis:confirmations_classes into 28a36af on particl:restructure.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 47.904% when pulling cd5fbfe on vikas-cis:confirmations_classes into 28a36af on particl:restructure.

@AllienWorks
Copy link
Member

Thanks, I've done my changes. Here's a preview:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 47.904% when pulling 8c76c00 on vikas-cis:confirmations_classes into 28a36af on particl:restructure.

@gerlofvanek gerlofvanek removed the request for review from pciavald December 1, 2017 15:37
@AllienWorks AllienWorks merged commit eeed654 into particl:restructure Dec 1, 2017
@AllienWorks AllienWorks added this to the v1.1 milestone Dec 1, 2017
@vikas-cis-zz
Copy link
Author

@AllienWorks Looks Awsome 👍

@AllienWorks
Copy link
Member

@vikas-cis teamwork ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllienWorks AllienWorks AllienWorks approved these changes

Assignees

@vikas-cis-zz vikas-cis-zz

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vikas-cis-zz @coveralls @AllienWorks @gerlofvanek @vikas-cis