replaces lost reset logic from 'feature/reset-network-flag' (fixes #1045) #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also adds CLR_WLAN_WD() when SYSTEM_FLAG_RESET_NETWORK_ON_CLOUD_ERRORS is disabled - handle_cloud_errors() was not displaying orange blinks due to HAL_Delay_Milliseconds() not blocking - handle_cloud_errors() was moved to the end of establish_cloud_connection() to ensure errors are shown - added debugging info for all of the places ARM_WLAN_WD/CLR_WLAN_WD is called - added new logic for notify_connected() to ensure ARM_WLAN_WD is not called after DHCP resolves successfully
|
just tested - issue still persists and is easily reproducible w/ this PR combined w/ #1047 |
|
@pomplesiegel hmm, did you try without merging with #1047? I wonder if a merge issue negated something. Testing these separately, they both appear to work 100% for me. I'll attempt to merge #1047 with this and test. |
- handle_cloud_errors() was fixed by making its process atomic, so that background system LED signaling did not interfere. - Because this fix causes a slight 1 to 1.5 second delay in system code execution, even when multi-threading is enabled. Not desireable, so for now we will disable this routine completely and defer enabling it again until the new LED handling routine is in place (0.6.x or 0.7.x). Also these particular blinks were never seen in the past, so existing behavior is preserved.
|
@pomplesiegel please give this one another test when you get a chance. I've tested it now with normal Tinker and multi-threaded Tinker with a blinking D7 LED and they both behave well for me. Thanks! |
|
@pomplesiegel just a friendly reminder, are issues with this PR are resolved for you now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doneness: