Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for RGB.onChange() handler leak #1352

Merged
merged 1 commit into from Jul 10, 2017

Conversation

@sergeuz
Copy link
Member

commented Jul 9, 2017

This PR adds a test for RGB.onChange() handler leak which was fixed in #1237


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (N/A)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Internal

  • [PR #1352] Added test for RGB.onChange() handler leak

@sergeuz sergeuz added this to the 0.7.0 milestone Jul 9, 2017

@sergeuz sergeuz requested a review from technobly Jul 9, 2017

@technobly technobly added the internal label Jul 10, 2017

@technobly technobly merged commit af9f76e into develop Jul 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/rgb_on_change_test branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.