Enable on demand vitals publishing #1724

zfields · 2019-03-14T00:07:24Z

Run .clang-format to homogenize new code
Complete the unit-tests
Draw up a test plan for end-to-end validation

Related Stories:

system/inc/system_dynalib_cloud.h

wiring/inc/spark_wiring_cloud.h

system/src/system_cloud.cpp

zfields · 2019-04-01T20:44:01Z

Having issues with Electron...

[UPDATE] Appears to have been a spurious error; cannot reproduce. Now working as expected.

… caused issues with WPA Ent authorization

communication/src/protocol.cpp

…wpa-ent-md5 [internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise)

API tests - compile only - confirm backward compatibilty of API E2E test - sample app

- Fix CMake to `--std=c++11` - Update header includes

Instead, leverage LOG_DISABLE macro to eliminate logging dependencies

Further disambiguate the Core specific implementation

- Set spark_protocol_post_description as a static member of the class to allow abstractions for using the system thread - Create on demand timer to simply construction, yet allow for mocking

m-mcgowan

The testing has some areas that need fixing up, but it's not so critical to delay this release.

m-mcgowan · 2019-04-05T13:58:59Z

user/tests/app/particle_publish_vitals/particle_publish_vitals.cpp

+ * Project: particle_publish_vitals
+ * Description: Confirm the functionality of the `Particle.publishVitals()` API
+ * Author: Zachary J. Fields
+ * Date: 13th March, 2019


This might seem like a nitpick, but we have generally moved away from putting creation dates, author and other attributions in files since they typically go out of date - we can find these things from the metadata in Github.

But 👍 to the project and description.

That's the boilerplate from Workbench (used to create the test application). Going forward, I will replace with something more general to Particle from elsewhere in the code.

m-mcgowan · 2019-04-05T14:00:58Z

user/tests/app/particle_publish_vitals/particle_publish_vitals.cpp

+bool final_publish = false;
+
+// setup() runs once, when the device is first turned on.
+void setup()


How about adding some cloud functions so that we can set the vitals publish period from the console?

I love that idea!

user/tests/wiring/api/cloud.cpp

m-mcgowan reviewed Mar 14, 2019

View reviewed changes

system/inc/system_dynalib_cloud.h Outdated Show resolved Hide resolved

m-mcgowan reviewed Mar 14, 2019

View reviewed changes

wiring/inc/spark_wiring_cloud.h Outdated Show resolved Hide resolved

zfields force-pushed the ch29186/vitals branch 5 times, most recently from 1ac0d05 to db1cd79 Compare March 21, 2019 15:26

zfields force-pushed the ch29186/vitals branch 3 times, most recently from b9a4fa4 to 707af8e Compare March 25, 2019 20:03

zfields commented Mar 26, 2019

View reviewed changes

system/src/system_cloud.cpp Outdated Show resolved Hide resolved

zfields force-pushed the ch29186/vitals branch 4 times, most recently from 05ef1c9 to 8bb925c Compare April 1, 2019 01:43

zfields marked this pull request as ready for review April 1, 2019 01:43

zfields force-pushed the ch29186/vitals branch from 8bb925c to 36a2188 Compare April 1, 2019 16:21

zfields added the DO NOT MERGE label Apr 1, 2019

zfields force-pushed the ch29186/vitals branch from 3d9103c to 765e630 Compare April 1, 2019 21:06

zfields removed the DO NOT MERGE label Apr 1, 2019

zfields force-pushed the ch29186/vitals branch 3 times, most recently from 79ab5dd to b29d1f9 Compare April 2, 2019 19:51

avtolstoy added needs review feature labels Apr 3, 2019

[photon/p1] crypto: accidentally disabled MD5 on Photon and P1, which…

8e87000

… caused issues with WPA Ent authorization

zfields requested a review from sergeuz April 4, 2019 16:38

zfields commented Apr 4, 2019

View reviewed changes

communication/src/protocol.cpp Outdated Show resolved Hide resolved

Merge pull request particle-iot#1743 from particle-iot/fix/photon-p1-…

8118508

…wpa-ent-md5 [internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise)

zfields added 21 commits April 11, 2019 10:15

Add Uri-Query option(s) to describe message

502a253

Move publish vitals period logic into system layer

c595fd3

Add Doxygen comments

bf2a72f

Add Fakeit submodule

d44796f

Further decouple VitalsPublisher

28623ef

Unit-test VitalsPublisher

45b6318

Reintegrate tested VitalsPublisher

3931d4d

Add API and E2E tests

8b3e9c8

API tests - compile only - confirm backward compatibilty of API E2E test - sample app

Apply .clang-format to new files

85ed69c

Update CMake CXX Standard

70a7519

- Fix CMake to `--std=c++11` - Update header includes

Incorporate feature switch PLATFORM_THREADING

b1bd610

Remove logging abstraction

919d095

Instead, leverage LOG_DISABLE macro to eliminate logging dependencies

Align with spec

aa8266b

Addressing small code review items

7817a3f

Rename SparkProtocol -> CoreProtocol

542eaaa

Further disambiguate the Core specific implementation

Refactor VitalsPublisher

9bccda3

- Set spark_protocol_post_description as a static member of the class to allow abstractions for using the system thread - Create on demand timer to simply construction, yet allow for mocking

Update unit-tests for refactored VitalsPublisher

06c791e

Fix dynamic library header

070578c

Export spark_protocol_to_system_error

7b927ba

Simplify VitalsPublisher implementation

f701eb2

Fix GCC build

d0e44f9

zfields force-pushed the ch29186/vitals branch from df15328 to 2d72171 Compare April 11, 2019 16:43

Add test plan for Particle.publishVitals

e61c26d

zfields force-pushed the ch29186/vitals branch from 2d72171 to e61c26d Compare April 11, 2019 17:04

m-mcgowan changed the base branch from develop to release/v1.2.0 April 11, 2019 19:21

m-mcgowan removed the needs review label Apr 12, 2019

m-mcgowan self-requested a review April 12, 2019 02:06

m-mcgowan approved these changes Apr 12, 2019

View reviewed changes

m-mcgowan merged commit 98f5cc4 into particle-iot:release/v1.2.0 Apr 12, 2019

zfields deleted the ch29186/vitals branch May 2, 2019 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable on demand vitals publishing #1724

Enable on demand vitals publishing #1724

zfields commented Mar 14, 2019 •

edited

Loading

zfields commented Apr 1, 2019 •

edited

Loading

m-mcgowan left a comment

m-mcgowan Apr 5, 2019

zfields Apr 12, 2019 •

edited

Loading

m-mcgowan Apr 5, 2019

zfields Apr 12, 2019

Enable on demand vitals publishing #1724

Enable on demand vitals publishing #1724

Conversation

zfields commented Mar 14, 2019 • edited Loading

zfields commented Apr 1, 2019 • edited Loading

m-mcgowan left a comment

Choose a reason for hiding this comment

m-mcgowan Apr 5, 2019

Choose a reason for hiding this comment

zfields Apr 12, 2019 • edited Loading

Choose a reason for hiding this comment

m-mcgowan Apr 5, 2019

Choose a reason for hiding this comment

zfields Apr 12, 2019

Choose a reason for hiding this comment

zfields commented Mar 14, 2019 •

edited

Loading

zfields commented Apr 1, 2019 •

edited

Loading

zfields Apr 12, 2019 •

edited

Loading