Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable on demand vitals publishing #1724

Merged
merged 66 commits into from Apr 12, 2019

Conversation

@zfields
Copy link
Contributor

commented Mar 14, 2019

  • Run .clang-format to homogenize new code
  • Complete the unit-tests
  • Draw up a test plan for end-to-end validation

Related Stories:

@zfields zfields force-pushed the zfields:ch29186/vitals branch 5 times, most recently from 1ac0d05 to db1cd79 Mar 15, 2019

@zfields zfields force-pushed the zfields:ch29186/vitals branch 3 times, most recently from b9a4fa4 to 707af8e Mar 25, 2019

system/src/system_cloud.cpp Outdated Show resolved Hide resolved

@zfields zfields force-pushed the zfields:ch29186/vitals branch 4 times, most recently from 05ef1c9 to 8bb925c Mar 27, 2019

@zfields zfields marked this pull request as ready for review Apr 1, 2019

@zfields zfields force-pushed the zfields:ch29186/vitals branch from 8bb925c to 36a2188 Apr 1, 2019

@zfields

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Having issues with Electron...

[UPDATE] Appears to have been a spurious error; cannot reproduce. Now working as expected.

@zfields zfields added the do not merge label Apr 1, 2019

@zfields zfields force-pushed the zfields:ch29186/vitals branch from 3d9103c to 765e630 Apr 1, 2019

@zfields zfields removed the do not merge label Apr 1, 2019

@zfields zfields force-pushed the zfields:ch29186/vitals branch 3 times, most recently from 79ab5dd to b29d1f9 Apr 2, 2019

[photon/p1] crypto: accidentally disabled MD5 on Photon and P1, which…
… caused issues with WPA Ent authorization

@zfields zfields requested a review from sergeuz Apr 4, 2019

communication/src/protocol.cpp Outdated Show resolved Hide resolved
Merge pull request #1743 from particle-iot/fix/photon-p1-wpa-ent-md5
[internal] [photon/p1] crypto: re-enables MD5 for TLS (WPA Enterprise)

@zfields zfields force-pushed the zfields:ch29186/vitals branch from df15328 to 2d72171 Apr 11, 2019

@zfields zfields force-pushed the zfields:ch29186/vitals branch from 2d72171 to e61c26d Apr 11, 2019

@m-mcgowan m-mcgowan changed the base branch from develop to release/v1.2.0 Apr 11, 2019

@m-mcgowan m-mcgowan removed the needs review label Apr 12, 2019

@m-mcgowan m-mcgowan self-requested a review Apr 12, 2019

@m-mcgowan
Copy link
Contributor

left a comment

The testing has some areas that need fixing up, but it's not so critical to delay this release.

* Project: particle_publish_vitals
* Description: Confirm the functionality of the `Particle.publishVitals()` API
* Author: Zachary J. Fields
* Date: 13th March, 2019

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Apr 12, 2019

Contributor

This might seem like a nitpick, but we have generally moved away from putting creation dates, author and other attributions in files since they typically go out of date - we can find these things from the metadata in Github.

But 👍 to the project and description.

This comment has been minimized.

Copy link
@zfields

zfields Apr 12, 2019

Author Contributor

That's the boilerplate from Workbench (used to create the test application). Going forward, I will replace with something more general to Particle from elsewhere in the code.

bool final_publish = false;

// setup() runs once, when the device is first turned on.
void setup()

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Apr 12, 2019

Contributor

How about adding some cloud functions so that we can set the vitals publish period from the console?

This comment has been minimized.

Copy link
@zfields

zfields Apr 12, 2019

Author Contributor

I love that idea!

user/tests/wiring/api/cloud.cpp Show resolved Hide resolved

@m-mcgowan m-mcgowan merged commit 98f5cc4 into particle-iot:release/v1.2.0 Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zfields zfields deleted the zfields:ch29186/vitals branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.