Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py and requirements.txt #10

Closed
karalekas opened this issue Nov 10, 2020 · 5 comments · Fixed by #13
Closed

Add setup.py and requirements.txt #10

karalekas opened this issue Nov 10, 2020 · 5 comments · Fixed by #13

Comments

@karalekas
Copy link
Contributor

These are essential for any Python project. They describe how to package and install the project, and how to set up a development environment for it in a repeatable way. As such, they are pre-requisites for implementing continuous integration.

@HGSilveri
Copy link
Collaborator

From what I've seen around, the requirements.txt is quite straightforward, although I still wonder: how can you determine what's the earliest version of a package that is required?

As for the setup.py, I've never done one myself and it seems complex, I could use some guidance with that.

@karalekas
Copy link
Contributor Author

@HGSilveri if it's ok with you I'm going to open a PR with a barebones setup.py to get you started, and we can work together to add more to it. As for the versions -- you don't necessarily have to specify them at the start. But we can discuss how you might go about doing that.

@karalekas karalekas self-assigned this Nov 10, 2020
@HGSilveri
Copy link
Collaborator

Alright, that sounds good. I'll use the same branch to include the requirements.txt (without versions for now) if that's ok with you.

@karalekas
Copy link
Contributor Author

I'll put a requirements.txt in the PR as well, but feel free to edit it if you like!

@HGSilveri
Copy link
Collaborator

Even better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants