Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minOrNull() #155

Closed
passsy opened this issue Oct 7, 2021 · 2 comments · Fixed by #170
Closed

Add minOrNull() #155

passsy opened this issue Oct 7, 2021 · 2 comments · Fixed by #170
Labels
Good First Issue Get started with open source and kt.dart hacktoberfest

Comments

@passsy
Copy link
Owner

passsy commented Oct 7, 2021

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/min-or-null.html
@passsy passsy added Good First Issue Get started with open source and kt.dart hacktoberfest labels Oct 7, 2021
@Anas35
Copy link
Contributor

Anas35 commented Oct 14, 2021 •
edited
Loading

The Kotlin min() and max() function which is already implemented, has been deprecated in favor of new name minOrNull() and maxOrNull(). Should we create a new function as minOrNull() with same implementation of min() and Deprecate the min() function ?

@passsy
Copy link
Owner Author

passsy commented Oct 14, 2021

Exactly. Then we should also deprecate the min/max functions when introducing minOrNull/maxOrNull

@Anas35 Anas35 mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Get started with open source and kt.dart hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add minOrNull(), maxOrNull() and deprecate min(), max() Anas35/kt.dart
2 participants
@passsy @Anas35