-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master branch to v0.15.0 #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method makes it possible to set all parameter properties in one go.
- Allow rfunc to be none, when no response function is used in the stressmodel - rfunc class is now instantiated in the stress model init, not in stressmodelbase
- Only parameter that are within the boundaries are now excepted when sampling from the multivariate normal distribution using truncation. - Solves issue #169 - Solves a new bug caused by Pandas reindexing
Methods otherwise take forever and run into memory problems
Only when the recharge model is Linear. This commit fixes the problem described in issue #120 Also, this commit fixes an error in StressModel2 where the evaporation times the factor was plotted in ml.plots.stresses. Now this factor is not applied when only plotting the stresses.
- Fix PEP8 - Add istress to docstring - Fix new Bug that was created when istress was not None, but nsplit !> 1 - improve efficiency
Make default rfunc in StressModelBase None #186
Don't run on travis because the Notebook depends on statsmodels.
Closing Issue #196
Introduce ArmaModel to Pastas
Bounds were unnecessarily small and improved initial values.
Differences compared to NoiseModel: 1. First value is residual 2. First weight is 1 / sig_residuals (i.e., delt = infty) 3. Sum of all weights is always 1
and update the initial parameters, these were the old ones.
Add a parameter to the Flexmodel that allows to update the potential evaporation. Default vary=False for this parameters, so it does not affect anything.
Much smaller makes no sense. This may cause problems in computation of the first few values in the four-parameter function, as it is integrated numerically.
New NoiseModel. See docs of NoiiseModel for differences with NoiseModelOld.
Ran the model to make sure it works with new noisemodel.
remove some old commented code
update notebook to include examples of other pastas read methods in future
Dinoloket read water level method
raoulcollenteur
requested review from
dbrakenhoff and
rubencalje
and removed request for
dbrakenhoff
July 31, 2020 10:25
dbrakenhoff
reviewed
Jul 31, 2020
dbrakenhoff
approved these changes
Jul 31, 2020
dbrakenhoff
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Update master branch to v0.15.0