Update Master-branch to v0.20.0 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obtain all signatures with a single method.
(was still travis)
- Some numerical errors. - Last time step for fluxes was not computed. - Set some sensible bounds for tt in snowmodel
The description of the Hantush well function was outdated. It corresponds now to the current implementation. No code was changed, just the Notebook.
ensure plotting order matches column order in parameters table
instead of secretly showing EVP
'HH' is still supported for older files
This fixed bugs with numba in tarso
Adressing Issue #370
Add Groundwater Signatures Module
Summary pdf
- raise error when simulation contains NaNs - do not extrapolate simulation (only interpolate to calculate residuals) - floor model tmin w freq - ceil model tmax w freq - fix nb changemodel to avoid error
- modify warnbounds section to general warnings section - warn if optimization returns success=False - warn if bounnds are hit - warn if response tmax exceeds calibration period - add method for comparison response tmax w calib period - improve formatting of fit report
This reverts commit e3e6c14.
- add logger info message when HantushWellModel is assuming r=1.0 - print warning when using WellModel if scipy version < 1.8
It can occur that for some of the lags the correlation is zero. In that case the arrays do not have an equal length and an error is thrown.
Improve fit report
define attribute in __init__ and correct solve. @dbrakenhoff .
- Prevent an error when beta equals exactly zero. - Same initial parameter settings as the AR1 models for alpha.
A new branch will be created for this work
Recharge Model Features - Peterson & Western / Flex (Groundwater Uptake)
dbrakenhoff
reviewed
Mar 29, 2022
| values during optimization. This means `ps.Leastsquares` is preferred solver in | ||
| most situations. The WellModel will no longer warn the user to use | ||
| `ps.LmFitSolve` if scipy>=1.8. | ||
|
|
There was a problem hiding this comment.
Update this list? Or is autogenerated changes sufficient?
There was a problem hiding this comment.
I was going for autogenerated changes from this version onwards. That will need better use of Issues, which is better for the overall quality anyways. :)
dbrakenhoff
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description