Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Master branch to 1.6 #762

Merged
merged 65 commits into from
Jun 25, 2024
Merged

Update Master branch to 1.6 #762

merged 65 commits into from
Jun 25, 2024

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Jun 4, 2024 •
edited
Loading

Short Description

Update master branch to Pastas 1.6.0.

Checklist before PR can be merged:

  • is documented
  • Format code with Ruff formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

raoulcollenteur and others added 30 commits April 24, 2024 09:46
@raoulcollenteur
update dev-branch to version 1.6.0b
44a3126
@OnnoEbbens
fix link to documentation in pyproj (#751)
ab06d0e
@martinvonk
add caching to load and list dataset
8b1cb7c
@martinvonk
add read_csv_kwargs to load_dataset
7e311f6
@martinvonk
add silent option to list_datasets
c178678
@martinvonk
Update test_dataset.py
a546f1c
@martinvonk
add requests to pastas[full] install
a0bd870
@martinvonk
silent=False in test to up coverage
b979317
@martinvonk
Seperate model summary plotting and pdf saving (#756)
526da56
@martinvonk
Raise exception if 0 samples are found within max_iter (#757)
521c239
@martinvonk
Change frequency offset based on Pandas version (#754)
c410865
@martinvonk
Create .pre-commit-config.yaml
2a69e7f
@martinvonk
update code style docs to ruff
d69913b
@martinvonk
update contributiong docs with pre-commit and ruff
2cef9aa
@martinvonk
update pool request template with ruff
8426d38
@martinvonk
update ci with formatting and linting with ruff
bb59b00
@martinvonk
typo in ruff check
e7dd508
@martinvonk
fix everything ruff does not like
74c5e25
@martinvonk
update ruff in pyproject.toml tox
914d409
@martinvonk
ruff formatting
d32f437
@martinvonk
remove --preview
609cc32
@martinvonk
check imports sorting/formatting
822a116
@martinvonk
rename unit tests ci
21e724c
@martinvonk
fix signatures helper function
170f2b8
@martinvonk
add logger debug to bare excepts
0ba2ce3
@raoulcollenteur
Caching load_dataset and adding read_csv_kwargs (#752)
20d03d0
@raoulcollenteur
Make SGI applicable to DataFrame and add Dropna
31febec
@martinvonk
Merge branch 'dev' into ruff_precommit
e192737
@martinvonk
fix pastas/dataset.py:139:13: F541 [*] f-string without any placeholders
ec4e3be
@raoulcollenteur
Make SGI applicable to DataFrame and add Dropna (#760)
ff1199b
@raoulcollenteur
Copy link
Member Author

This can be merged after merging #769 into dev.

dbrakenhoff
dbrakenhoff approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor documentation/docstring comments here and there. But otherwise looks good to go!

doc/developers/code_style.rst Outdated Show resolved Hide resolved
doc/developers/contributing.rst Outdated Show resolved Hide resolved
doc/developers/contributing.rst Outdated Show resolved Hide resolved
doc/developers/contributing.rst Outdated Show resolved Hide resolved
doc/developers/contributing.rst Outdated Show resolved Hide resolved
@raoulcollenteur raoulcollenteur merged commit b214d48 into master Jun 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

@martinvonk martinvonk Awaiting requested review from martinvonk

Assignees

@raoulcollenteur raoulcollenteur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@raoulcollenteur @dbrakenhoff @OnnoEbbens @martinvonk @rubencalje @AviMuni @AviadAvr