Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline after_commit do blocks <-> make ar_after_transaction obsolote #7

Closed
grosser opened this issue Oct 3, 2011 · 1 comment

Comments

@grosser
Copy link

grosser commented Oct 3, 2011

I have a similar project (ar_after_transaction)[https://github.com/grosser/ar_after_transaction] that fixes the same problems, but also adds a after_transaction do block style callback, so users can e.g.

after_create :do_stuff, :oops

def do_stuff
  after_transaction do
    send_an_email # cannot be rolled back
  end
  comments.create(...) # will be rolled back
end

Is it possilbe to include this behavior -> id like to mark the project as obsolete and just link here.

@pat
Copy link
Owner

pat commented Oct 3, 2011

Hi Michael

That's currently not possible in after_commit, but if you want to fork and patch it, I'll happily merge it in.

Pat

On 04/10/2011, at 1:59 AM, Michael Grosser wrote:

I have a similar project (ar_after_transaction)[https://github.com/grosser/ar_after_transaction] that fixes the same problems, but also adds a after_transaction do block style callback, so users can e.g.

after_create :do_stuff, :oops

def do_stuff
after_transaction do
send_an_email # cannot be rolled back
end
comments.create(...) # will be rolled back
end

Is it possilbe to include this behavior -> id like to mark the project as obsolete and just link here.

Reply to this email directly or view it on GitHub:
https://github.com/freelancing-god/after_commit/issues/7

@pat pat closed this as completed Aug 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants