Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion block not being called #47

Closed
tonyxiao opened this issue Feb 24, 2014 · 1 comment
Closed

Completion block not being called #47

tonyxiao opened this issue Feb 24, 2014 · 1 comment

Comments

@tonyxiao
Copy link

https://github.com/path/FastImageCache/blob/master/FastImageCache/FICImageCache.m#L226

If delegate gives back nil for entity, then completion block in asynchronouslyRetrieveImageForEntity:withFormatName:completionBlock will not be called, breaking the API contract and documentation, which says

 @note You can always rely on the completion block being called. If an error occurs for any reason, the `image` parameter of the completion block will be `nil`. See
@ghost
Copy link

ghost commented Mar 12, 2014

Fixed by commit 213a3ff.

@ghost ghost closed this as completed Mar 12, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant